You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/21 17:22:50 UTC

[GitHub] [tvm] mbrookhart opened a new pull request #7899: [ONNX] Support importing Conv with missing attributes

mbrookhart opened a new pull request #7899:
URL: https://github.com/apache/tvm/pull/7899


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] mbrookhart commented on pull request #7899: [ONNX] Support importing Conv with missing attributes

Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #7899:
URL: https://github.com/apache/tvm/pull/7899#issuecomment-825141189


   I found the issue by going to onnxruntime 1.2.0. I missed a case where dilation was the the default value, so I dropped it by mistake.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] mbrookhart commented on pull request #7899: [ONNX] Support importing Conv with missing attributes

Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #7899:
URL: https://github.com/apache/tvm/pull/7899#issuecomment-824955370


   huh, this is an onnxruntime error...
   
   I can't seem to install the version of onnx runtime we're using in CI, it's not in pip...
   
   Will try to debug.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] jwfromm merged pull request #7899: [ONNX] Support importing Conv with missing attributes

Posted by GitBox <gi...@apache.org>.
jwfromm merged pull request #7899:
URL: https://github.com/apache/tvm/pull/7899


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] jwfromm commented on pull request #7899: [ONNX] Support importing Conv with missing attributes

Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7899:
URL: https://github.com/apache/tvm/pull/7899#issuecomment-825793536


   Thanks @mbrookhart! This is now merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] jwfromm commented on pull request #7899: [ONNX] Support importing Conv with missing attributes

Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7899:
URL: https://github.com/apache/tvm/pull/7899#issuecomment-824568275


   @mbrookhart it looks like one of the onnx test nodes is constructed with a bad output shape.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org