You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/12/03 20:29:06 UTC
[GitHub] [geode] kirklund opened a new pull request #7165: GEODE-9785: Move SanctionedSerializables to serialization.filter
kirklund opened a new pull request #7165:
URL: https://github.com/apache/geode/pull/7165
Serialization filtering pull requests can be very large so it may be
better to submit this change separately to help with reviews.
Move SanctionedSerializables and SanctionedSerializablesService
to serialization.filter package.
Add new SanctionedSerializablesServiceIntegrationTests to every
Geode module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot commented on a change in pull request #7165: GEODE-9785: Move SanctionedSerializables to serialization.filter
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on a change in pull request #7165:
URL: https://github.com/apache/geode/pull/7165#discussion_r763221638
##########
File path: geode-common/build.gradle
##########
@@ -34,9 +34,10 @@ dependencies {
// test
testImplementation('junit:junit')
- testRuntimeOnly('org.junit.vintage:junit-vintage-engine')
+ testImplementation('org.apache.commons:commons-lang3')
testImplementation('org.assertj:assertj-core')
testImplementation('org.mockito:mockito-core')
+ testRuntimeOnly('org.junit.vintage:junit-vintage-engine')
Review comment:
Thanks for fixing the ordering.
##########
File path: geode-core/build.gradle
##########
@@ -331,6 +331,7 @@ dependencies {
exclude module: 'geode-core'
}
testImplementation(project(':geode-concurrency-test'))
+ testImplementation(project(':geode-serialization'))
Review comment:
should not be needed, since `testImplementation` extends from `implementation` but I like the precision of adding it.
##########
File path: geode-core/build.gradle
##########
@@ -354,6 +355,7 @@ dependencies {
integrationTestImplementation(project(':geode-dunit'))
integrationTestImplementation(project(':geode-log4j'))
integrationTestImplementation(project(':geode-concurrency-test'))
+ integrationTestImplementation(project(':geode-serialization'))
Review comment:
should not be needed, since `integrationTestImplementation` extends from `implementation` but I like the precision of adding it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kirklund merged pull request #7165: GEODE-9758: Move SanctionedSerializables to filter package
Posted by GitBox <gi...@apache.org>.
kirklund merged pull request #7165:
URL: https://github.com/apache/geode/pull/7165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kirklund commented on pull request #7165: GEODE-9758: Move SanctionedSerializables to filter package
Posted by GitBox <gi...@apache.org>.
kirklund commented on pull request #7165:
URL: https://github.com/apache/geode/pull/7165#issuecomment-988275726
Both precheckin failures are known flaky tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org