[GitHub] flink pull request #4977: [FLINK-7996] [table] Add support for (left.time = ...

[xccui <gi...@git.apache.org>]

GitHub user xccui opened a pull request:

    https://github.com/apache/flink/pull/4977

    [FLINK-7996] [table] Add support for (left.time = right.time) predicates to window join

    ## What is the purpose of the change
    
    This PR adds `left.time = right.time` predicates support for time-windowed join in Table API and SQL.
    
    ## Brief change log
    
      - Change `WindowJoinUtil.extractWindowBoundsFromPredicate()` to accept single euqi-time predicate.
      - Add tests for the new predicate.
      - Update the documents.
    
    ## Verifying this change
    
    This change can be verified by the added tests in `JoinTest` and `JoinITCase`.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (yes / no / don't know)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (docs)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xccui/flink FLINK-7996

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4977.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4977
    
----
commit 03d54c672f4a529c1cf0e3af3e74d60fb37febb7
Author: Xingcan Cui <xi...@gmail.com>
Date:   2017-11-07T17:17:57Z

    [FLINK-7996][table]Add support for (left.time = right.time) predicates to window join

----


---

[GitHub] flink issue #4977: [FLINK-7996] [table] Add support for (left.time = right.t...

[fhueske <gi...@git.apache.org>]

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/4977
  
    Thanks for the PR @xccui.
    I'll do some minor refactorings and will merge it.
    
    Thanks, Fabian


---

[GitHub] flink pull request #4977: [FLINK-7996] [table] Add support for (left.time = ...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4977


---