[GitHub] [thrift] Jens-G commented on a diff in pull request #2469: THRIFT-5423: Support go parameter validation in IDL

[GitBox <gi...@apache.org>]

Jens-G commented on code in PR #2469:
URL: https://github.com/apache/thrift/pull/2469#discussion_r965198333


##########
CHANGES.md:
##########
@@ -9,6 +9,7 @@
 - [THRIFT-5527](https://issues.apache.org/jira/browse/THRIFT-5527) - Compiler generated Process function will swallow exceptions defined in thrift IDL
 - [THRIFT-5605](https://issues.apache.org/jira/browse/THRIFT-5605) - Provide `ExtractIDLExceptionClientMiddleware` and `ExtractExceptionFromResult` to help client middlewares to gain access to exceptions defined in thrift IDL
 - [THRIFT-5609](https://issues.apache.org/jira/browse/THRIFT-5609) - `TJSONProtocol` is now safe to be used in `TDeserializePool`
+- [THRIFT-5423](https://issues.apache.org/jira/browse/THRIFT-5423) - Specify thrift parameter validation proposal and provide parameter validator for go language.

Review Comment:
   Usually not necessary, since the changes.md file will be [assembled during release process](https://github.com/apache/thrift/blob/master/doc/ReleaseManagement.md#release-candidate). 
   But what you might want to include beforehand is [breaking changes](https://github.com/apache/thrift/blob/master/CHANGES.md#breaking-changes).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org