[GitHub] [sling-parent] kwin commented on a change in pull request #5: SLING-8199 - Allow building for Java 10, 11 and 12

[GitBox <gi...@apache.org>]

kwin commented on a change in pull request #5: SLING-8199 - Allow building for Java 10, 11 and 12
URL: https://github.com/apache/sling-parent/pull/5#discussion_r269995274
 
 

 ##########
 File path: sling-parent/pom.xml
 ##########
 @@ -118,13 +119,29 @@
                           <goal>enforce</goal>
                         </goals>
                         <configuration>
-                          <rules>
-                            <requireProperty>
-                              <property>sling.java.version</property>
-                              <regex>[6-9]</regex>
-                              <regexMessage>The property "sling.java.version" may only have one of the following values: 6, 7, 8 or 9.</regexMessage>
-                            </requireProperty>
-                          </rules>
+                            <rules>
+                                <requireProperty>
+                                    <property>sling.java.version</property>
+                                    <regex>^(8|9|1[0-9])$</regex>
+                                    <regexMessage>
+                                        The value of the "sling.java.version" property should comply with the following rule: ^(8|9|1[0-9])$.
 
 Review comment:
   rule -> pattern?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services