You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/29 23:17:50 UTC
[GitHub] [spark] maropu opened a new pull request #30191: [SPARK-33268][SQL][PYTHON][3.0] Fix bugs for casting data from/to PythonUserDefinedType
maropu opened a new pull request #30191:
URL: https://github.com/apache/spark/pull/30191
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR intends to fix bugs for casting data from/to PythonUserDefinedType. A sequence of queries to reproduce this issue is as follows;
```
>>> from pyspark.sql import Row
>>> from pyspark.sql.functions import col
>>> from pyspark.sql.types import *
>>> from pyspark.testing.sqlutils import *
>>>
>>> row = Row(point=ExamplePoint(1.0, 2.0))
>>> df = spark.createDataFrame([row])
>>> df.select(col("point").cast(PythonOnlyUDT()))
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/maropu/Repositories/spark/spark-master/python/pyspark/sql/dataframe.py", line 1402, in select
jdf = self._jdf.select(self._jcols(*cols))
File "/Users/maropu/Repositories/spark/spark-master/python/lib/py4j-0.10.9-src.zip/py4j/java_gateway.py", line 1305, in __call__
File "/Users/maropu/Repositories/spark/spark-master/python/pyspark/sql/utils.py", line 111, in deco
return f(*a, **kw)
File "/Users/maropu/Repositories/spark/spark-master/python/lib/py4j-0.10.9-src.zip/py4j/protocol.py", line 328, in get_return_value
py4j.protocol.Py4JJavaError: An error occurred while calling o44.select.
: java.lang.NullPointerException
at org.apache.spark.sql.types.UserDefinedType.acceptsType(UserDefinedType.scala:84)
at org.apache.spark.sql.catalyst.expressions.Cast$.canCast(Cast.scala:96)
at org.apache.spark.sql.catalyst.expressions.CastBase.checkInputDataTypes(Cast.scala:267)
at org.apache.spark.sql.catalyst.expressions.CastBase.resolved$lzycompute(Cast.scala:290)
at org.apache.spark.sql.catalyst.expressions.CastBase.resolved(Cast.scala:290)
```
A root cause of this issue is that, since `PythonUserDefinedType#userClassis` always null, `isAssignableFrom` in `UserDefinedType#acceptsType` throws a null exception. To fix it, this PR defines `acceptsType` in `PythonUserDefinedType` and filters out the null case in `UserDefinedType#acceptsType`.
This backport comes from https://github.com/apache/spark/pull/30169.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Bug fixes.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30191: [SPARK-33268][SQL][PYTHON][3.0] Fix bugs for casting data from/to PythonUserDefinedType
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30191:
URL: https://github.com/apache/spark/pull/30191#issuecomment-719078571
**[Test build #130420 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130420/testReport)** for PR 30191 at commit [`1eaff04`](https://github.com/apache/spark/commit/1eaff043b78d94bce1bf62104f02a13acf3605f5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30191: [SPARK-33268][SQL][PYTHON][3.0] Fix bugs for casting data from/to PythonUserDefinedType
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30191:
URL: https://github.com/apache/spark/pull/30191#issuecomment-719097279
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35024/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30191: [SPARK-33268][SQL][PYTHON][3.0] Fix bugs for casting data from/to PythonUserDefinedType
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30191:
URL: https://github.com/apache/spark/pull/30191#issuecomment-719170452
**[Test build #130420 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130420/testReport)** for PR 30191 at commit [`1eaff04`](https://github.com/apache/spark/commit/1eaff043b78d94bce1bf62104f02a13acf3605f5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #30191: [SPARK-33268][SQL][PYTHON][3.0] Fix bugs for casting data from/to PythonUserDefinedType
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30191:
URL: https://github.com/apache/spark/pull/30191#issuecomment-719078038
NOTE: I'll open a PR soon to backport it into branch-2.4., too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30191: [SPARK-33268][SQL][PYTHON][3.0] Fix bugs for casting data from/to PythonUserDefinedType
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30191:
URL: https://github.com/apache/spark/pull/30191#issuecomment-719078571
**[Test build #130420 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130420/testReport)** for PR 30191 at commit [`1eaff04`](https://github.com/apache/spark/commit/1eaff043b78d94bce1bf62104f02a13acf3605f5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30191: [SPARK-33268][SQL][PYTHON][3.0] Fix bugs for casting data from/to PythonUserDefinedType
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30191:
URL: https://github.com/apache/spark/pull/30191#issuecomment-719097266
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35024/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #30191: [SPARK-33268][SQL][PYTHON][3.0] Fix bugs for casting data from/to PythonUserDefinedType
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30191:
URL: https://github.com/apache/spark/pull/30191#issuecomment-719152096
Thanks, all ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30191: [SPARK-33268][SQL][PYTHON][3.0] Fix bugs for casting data from/to PythonUserDefinedType
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30191:
URL: https://github.com/apache/spark/pull/30191
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30191: [SPARK-33268][SQL][PYTHON][3.0] Fix bugs for casting data from/to PythonUserDefinedType
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30191:
URL: https://github.com/apache/spark/pull/30191#issuecomment-719172503
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30191: [SPARK-33268][SQL][PYTHON][3.0] Fix bugs for casting data from/to PythonUserDefinedType
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30191:
URL: https://github.com/apache/spark/pull/30191#issuecomment-719172503
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30191: [SPARK-33268][SQL][PYTHON][3.0] Fix bugs for casting data from/to PythonUserDefinedType
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30191:
URL: https://github.com/apache/spark/pull/30191#issuecomment-719091746
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35024/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30191: [SPARK-33268][SQL][PYTHON][3.0] Fix bugs for casting data from/to PythonUserDefinedType
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30191:
URL: https://github.com/apache/spark/pull/30191#issuecomment-719097277
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30191: [SPARK-33268][SQL][PYTHON][3.0] Fix bugs for casting data from/to PythonUserDefinedType
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30191:
URL: https://github.com/apache/spark/pull/30191#issuecomment-719077570
Thanks, @maropu !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30191: [SPARK-33268][SQL][PYTHON][3.0] Fix bugs for casting data from/to PythonUserDefinedType
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30191:
URL: https://github.com/apache/spark/pull/30191#issuecomment-719097277
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org