[Bug 62686] New: Very inconspicuous bug.

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62686

            Bug ID: 62686
           Summary: Very inconspicuous bug.
           Product: Ant
           Version: unspecified
          Hardware: PC
                OS: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Core
          Assignee: notifications@ant.apache.org
          Reporter: raubirius@gmail.com
  Target Milestone: ---

There is a bug in ZipOutputStream.java in method setLevel(int) at the line(s):

        hasCompressionLevelChanged = (this.level != level);
        this.level = level;

This is bad strategy…

Consider following scenario:

        – Level does not equal to 5.
        – User invokes setLevel(5).
        – There is no putNextEntry (nor another relevant method) call in
between…
        – User invokes setLevel(5) again.
        – User invokes putNextEntry(…) which will get invalid information about
the change of compression level.

I suggest to change the line(s) as follows:

        if (this.level != level)
        {
                hasCompressionLevelChanged = true;
                this.level = level;
        }

(Similar bugs may be hidden on another places…)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 62686] Very inconspicuous bug.

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62686

--- Comment #2 from Roman Horváth <ra...@gmail.com> ---
Yes, thank you for reply and acceptance… :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 62686] Very inconspicuous bug.

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62686

Jaikiran Pai <ja...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |1.9.14
         Resolution|---                         |FIXED

--- Comment #1 from Jaikiran Pai <ja...@apache.org> ---
That indeed is a bug. Thank you for reporting it. We have pushed a fix for this
to 1.9.x as well as master branches. Our next release 1.9.14 and 1.10.6 (when
they happen) should include this fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.