[GitHub] [hbase] ddupg commented on a change in pull request #2966: HBASE-25562 ReplicationSourceWALReader log and handle exception immed…

[GitBox <gi...@apache.org>]

ddupg commented on a change in pull request #2966:
URL: https://github.com/apache/hbase/pull/2966#discussion_r580033201



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java
##########
@@ -147,14 +147,13 @@ public void run() {
           }
         }
       } catch (IOException e) { // stream related
-        if (sleepMultiplier < maxRetriesMultiplier) {
-          LOG.debug("Failed to read stream of replication entries: " + e);
-          sleepMultiplier++;
-        } else {
-          LOG.error("Failed to read stream of replication entries", e);
-          handleEofException(e);
+        if (!handleEofException(e)) {

Review comment:
       Thank @sandeepvinayak for reviewing.
   How about keeping resetting `sleepMultiplier` only in [there](https://github.com/apache/hbase/blob/1a703f48e90b985b00aeee1f1de6c876e60acd68/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java#L143) where read WAL successfully? What I'm thinking is that `handleEofException` just deals with exceptions and we still need to retry to get back to the correct logic. We reset `sleepMultiplier` only after the logic getting back correct?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org