[GitHub] [pulsar] BewareMyPower opened a new pull request, #15969: [cleanup][broker] Remove redundant `messagesForC` check in multi-consumer dispatcher

[GitBox <gi...@apache.org>]

BewareMyPower opened a new pull request, #15969:
URL: https://github.com/apache/pulsar/pull/15969

   ### Motivation
   
   In `PersistentDispatcherMultipleConsumers#sendMessagesToConsumers`, it
   checks `messagesForC > 0` while `messagesForC` is always greater than 0.
   
   ### Modifications
   
   Remove the `if (messagesForC > 0)` check. In addition, call
   `entries.subList(start, end)` before handling the replace case to avoid
   `subList` being called twice.
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower merged pull request #15969: [cleanup][broker] Remove redundant `messagesForC` check in multi-consumer dispatcher

[GitBox <gi...@apache.org>]

BewareMyPower merged PR #15969:
URL: https://github.com/apache/pulsar/pull/15969


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org