You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Mehmet Zahid Yuzuguldu <zy...@gmail.com> on 2015/11/09 10:24:58 UTC
Review Request 40073: Checking selinux status on each host when
creating new cluster
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40073/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
Repository: ambari
Description
-------
Adding checking selinux status mechanism on each host when creating new cluster.
Diffs
-----
ambari-server/src/main/resources/custom_actions/scripts/check_host.py 8b49725
ambari-web/app/controllers/wizard/step3_controller.js cf1f1ae
ambari-web/app/messages.js 78c439b
ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 9c6454e
ambari-web/app/views/wizard/step3_view.js 6ecfb41
ambari-web/test/views/wizard/step3/hostWarningPopupBody_view_test.js 3cd53a0
Diff: https://reviews.apache.org/r/40073/diff/
Testing
-------
Thanks,
Mehmet Zahid Yuzuguldu
Re: Review Request 40073: Checking selinux status on each host when
creating new cluster
Posted by Mehmet Zahid Yuzuguldu <zy...@gmail.com>.
> On Nov. 12, 2015, 7:54 a.m., Andrew Onischuk wrote:
> > I don't think we need this feature. Anyways we force turing off selinux before installing on Ambari.
> >
> > Execute(("setenforce","0"),
> > only_if="test -f /selinux/enforce",
> > not_if="(! which getenforce ) || (which getenforce && getenforce | grep -q Disabled)",
> > sudo=True,
> > )
>
> Mehmet Zahid Yuzuguldu wrote:
> i see that, but this can be happen if selinux is activated after installed before adding new cluster.
> We got this senario in our hadoop ecosystem
>
> Andrew Onischuk wrote:
> But adding new cluster will trigger INSTALL tasks which will trigger "setenforce 0". Am I missing something?
>
> Mehmet Zahid Yuzuguldu wrote:
> Ok, this is for manual installing ambari-agent and not adding new cluster just after installing ambari-agent.
>
> Andrew Onischuk wrote:
> anyway you should add the ambari-agent to cluster and install something on it, to do anything on it.
So, cancelling this pathc?
- Mehmet Zahid
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40073/#review106204
-----------------------------------------------------------
On Nov. 12, 2015, 7:29 a.m., Mehmet Zahid Yuzuguldu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40073/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 7:29 a.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-13733
> https://issues.apache.org/jira/browse/AMBARI-13733
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Adding checking selinux status mechanism on each host when creating new cluster.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/custom_actions/scripts/check_host.py 8b49725
> ambari-web/app/controllers/wizard/step3_controller.js cf1f1ae
> ambari-web/app/messages.js 78c439b
> ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 9c6454e
> ambari-web/app/views/wizard/step3_view.js 6ecfb41
> ambari-web/test/views/wizard/step3/hostWarningPopupBody_view_test.js 3cd53a0
>
> Diff: https://reviews.apache.org/r/40073/diff/
>
>
> Testing
> -------
>
> Manual testing done.
> ======
>
> Ambar-web
> mvn clean test
>
> 10080 tests complete (11 seconds)
> 105 tests pending
>
>
> Thanks,
>
> Mehmet Zahid Yuzuguldu
>
>
Re: Review Request 40073: Checking selinux status on each host when
creating new cluster
Posted by Mehmet Zahid Yuzuguldu <zy...@gmail.com>.
> On Nov. 12, 2015, 7:54 a.m., Andrew Onischuk wrote:
> > I don't think we need this feature. Anyways we force turing off selinux before installing on Ambari.
> >
> > Execute(("setenforce","0"),
> > only_if="test -f /selinux/enforce",
> > not_if="(! which getenforce ) || (which getenforce && getenforce | grep -q Disabled)",
> > sudo=True,
> > )
i see that, but this can be happen if selinux is activated after installed before adding new cluster.
We got this senario in our hadoop ecosystem
- Mehmet Zahid
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40073/#review106204
-----------------------------------------------------------
On Nov. 12, 2015, 7:29 a.m., Mehmet Zahid Yuzuguldu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40073/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 7:29 a.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-13733
> https://issues.apache.org/jira/browse/AMBARI-13733
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Adding checking selinux status mechanism on each host when creating new cluster.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/custom_actions/scripts/check_host.py 8b49725
> ambari-web/app/controllers/wizard/step3_controller.js cf1f1ae
> ambari-web/app/messages.js 78c439b
> ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 9c6454e
> ambari-web/app/views/wizard/step3_view.js 6ecfb41
> ambari-web/test/views/wizard/step3/hostWarningPopupBody_view_test.js 3cd53a0
>
> Diff: https://reviews.apache.org/r/40073/diff/
>
>
> Testing
> -------
>
> Manual testing done.
> ======
>
> Ambar-web
> mvn clean test
>
> 10080 tests complete (11 seconds)
> 105 tests pending
>
>
> Thanks,
>
> Mehmet Zahid Yuzuguldu
>
>
Re: Review Request 40073: Checking selinux status on each host when
creating new cluster
Posted by Mehmet Zahid Yuzuguldu <zy...@gmail.com>.
> On Nov. 12, 2015, 7:54 a.m., Andrew Onischuk wrote:
> > I don't think we need this feature. Anyways we force turing off selinux before installing on Ambari.
> >
> > Execute(("setenforce","0"),
> > only_if="test -f /selinux/enforce",
> > not_if="(! which getenforce ) || (which getenforce && getenforce | grep -q Disabled)",
> > sudo=True,
> > )
>
> Mehmet Zahid Yuzuguldu wrote:
> i see that, but this can be happen if selinux is activated after installed before adding new cluster.
> We got this senario in our hadoop ecosystem
>
> Andrew Onischuk wrote:
> But adding new cluster will trigger INSTALL tasks which will trigger "setenforce 0". Am I missing something?
Ok, this is for manual installing ambari-agent and not adding new cluster just after installing ambari-agent.
- Mehmet Zahid
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40073/#review106204
-----------------------------------------------------------
On Nov. 12, 2015, 7:29 a.m., Mehmet Zahid Yuzuguldu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40073/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 7:29 a.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-13733
> https://issues.apache.org/jira/browse/AMBARI-13733
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Adding checking selinux status mechanism on each host when creating new cluster.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/custom_actions/scripts/check_host.py 8b49725
> ambari-web/app/controllers/wizard/step3_controller.js cf1f1ae
> ambari-web/app/messages.js 78c439b
> ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 9c6454e
> ambari-web/app/views/wizard/step3_view.js 6ecfb41
> ambari-web/test/views/wizard/step3/hostWarningPopupBody_view_test.js 3cd53a0
>
> Diff: https://reviews.apache.org/r/40073/diff/
>
>
> Testing
> -------
>
> Manual testing done.
> ======
>
> Ambar-web
> mvn clean test
>
> 10080 tests complete (11 seconds)
> 105 tests pending
>
>
> Thanks,
>
> Mehmet Zahid Yuzuguldu
>
>
Re: Review Request 40073: Checking selinux status on each host when
creating new cluster
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On Nov. 12, 2015, 7:54 a.m., Andrew Onischuk wrote:
> > I don't think we need this feature. Anyways we force turing off selinux before installing on Ambari.
> >
> > Execute(("setenforce","0"),
> > only_if="test -f /selinux/enforce",
> > not_if="(! which getenforce ) || (which getenforce && getenforce | grep -q Disabled)",
> > sudo=True,
> > )
>
> Mehmet Zahid Yuzuguldu wrote:
> i see that, but this can be happen if selinux is activated after installed before adding new cluster.
> We got this senario in our hadoop ecosystem
But adding new cluster will trigger INSTALL tasks which will trigger "setenforce 0". Am I missing something?
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40073/#review106204
-----------------------------------------------------------
On Nov. 12, 2015, 7:29 a.m., Mehmet Zahid Yuzuguldu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40073/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 7:29 a.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-13733
> https://issues.apache.org/jira/browse/AMBARI-13733
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Adding checking selinux status mechanism on each host when creating new cluster.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/custom_actions/scripts/check_host.py 8b49725
> ambari-web/app/controllers/wizard/step3_controller.js cf1f1ae
> ambari-web/app/messages.js 78c439b
> ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 9c6454e
> ambari-web/app/views/wizard/step3_view.js 6ecfb41
> ambari-web/test/views/wizard/step3/hostWarningPopupBody_view_test.js 3cd53a0
>
> Diff: https://reviews.apache.org/r/40073/diff/
>
>
> Testing
> -------
>
> Manual testing done.
> ======
>
> Ambar-web
> mvn clean test
>
> 10080 tests complete (11 seconds)
> 105 tests pending
>
>
> Thanks,
>
> Mehmet Zahid Yuzuguldu
>
>
Re: Review Request 40073: Checking selinux status on each host when
creating new cluster
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On Nov. 12, 2015, 7:54 a.m., Andrew Onischuk wrote:
> > I don't think we need this feature. Anyways we force turing off selinux before installing on Ambari.
> >
> > Execute(("setenforce","0"),
> > only_if="test -f /selinux/enforce",
> > not_if="(! which getenforce ) || (which getenforce && getenforce | grep -q Disabled)",
> > sudo=True,
> > )
>
> Mehmet Zahid Yuzuguldu wrote:
> i see that, but this can be happen if selinux is activated after installed before adding new cluster.
> We got this senario in our hadoop ecosystem
>
> Andrew Onischuk wrote:
> But adding new cluster will trigger INSTALL tasks which will trigger "setenforce 0". Am I missing something?
>
> Mehmet Zahid Yuzuguldu wrote:
> Ok, this is for manual installing ambari-agent and not adding new cluster just after installing ambari-agent.
>
> Andrew Onischuk wrote:
> anyway you should add the ambari-agent to cluster and install something on it, to do anything on it.
>
> Mehmet Zahid Yuzuguldu wrote:
> So, cancelling this pathc?
Unless there is any reasonable purpose for the change. Currently I don't see one, which is my main concern.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40073/#review106204
-----------------------------------------------------------
On Nov. 12, 2015, 7:29 a.m., Mehmet Zahid Yuzuguldu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40073/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 7:29 a.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-13733
> https://issues.apache.org/jira/browse/AMBARI-13733
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Adding checking selinux status mechanism on each host when creating new cluster.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/custom_actions/scripts/check_host.py 8b49725
> ambari-web/app/controllers/wizard/step3_controller.js cf1f1ae
> ambari-web/app/messages.js 78c439b
> ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 9c6454e
> ambari-web/app/views/wizard/step3_view.js 6ecfb41
> ambari-web/test/views/wizard/step3/hostWarningPopupBody_view_test.js 3cd53a0
>
> Diff: https://reviews.apache.org/r/40073/diff/
>
>
> Testing
> -------
>
> Manual testing done.
> ======
>
> Ambar-web
> mvn clean test
>
> 10080 tests complete (11 seconds)
> 105 tests pending
>
>
> Thanks,
>
> Mehmet Zahid Yuzuguldu
>
>
Re: Review Request 40073: Checking selinux status on each host when
creating new cluster
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On Nov. 12, 2015, 7:54 a.m., Andrew Onischuk wrote:
> > I don't think we need this feature. Anyways we force turing off selinux before installing on Ambari.
> >
> > Execute(("setenforce","0"),
> > only_if="test -f /selinux/enforce",
> > not_if="(! which getenforce ) || (which getenforce && getenforce | grep -q Disabled)",
> > sudo=True,
> > )
>
> Mehmet Zahid Yuzuguldu wrote:
> i see that, but this can be happen if selinux is activated after installed before adding new cluster.
> We got this senario in our hadoop ecosystem
>
> Andrew Onischuk wrote:
> But adding new cluster will trigger INSTALL tasks which will trigger "setenforce 0". Am I missing something?
>
> Mehmet Zahid Yuzuguldu wrote:
> Ok, this is for manual installing ambari-agent and not adding new cluster just after installing ambari-agent.
anyway you should add the ambari-agent to cluster and install something on it, to do anything on it.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40073/#review106204
-----------------------------------------------------------
On Nov. 12, 2015, 7:29 a.m., Mehmet Zahid Yuzuguldu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40073/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 7:29 a.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-13733
> https://issues.apache.org/jira/browse/AMBARI-13733
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Adding checking selinux status mechanism on each host when creating new cluster.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/custom_actions/scripts/check_host.py 8b49725
> ambari-web/app/controllers/wizard/step3_controller.js cf1f1ae
> ambari-web/app/messages.js 78c439b
> ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 9c6454e
> ambari-web/app/views/wizard/step3_view.js 6ecfb41
> ambari-web/test/views/wizard/step3/hostWarningPopupBody_view_test.js 3cd53a0
>
> Diff: https://reviews.apache.org/r/40073/diff/
>
>
> Testing
> -------
>
> Manual testing done.
> ======
>
> Ambar-web
> mvn clean test
>
> 10080 tests complete (11 seconds)
> 105 tests pending
>
>
> Thanks,
>
> Mehmet Zahid Yuzuguldu
>
>
Re: Review Request 40073: Checking selinux status on each host when
creating new cluster
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40073/#review106204
-----------------------------------------------------------
I don't think we need this feature. Anyways we force turing off selinux before installing on Ambari.
Execute(("setenforce","0"),
only_if="test -f /selinux/enforce",
not_if="(! which getenforce ) || (which getenforce && getenforce | grep -q Disabled)",
sudo=True,
)
- Andrew Onischuk
On Nov. 12, 2015, 7:29 a.m., Mehmet Zahid Yuzuguldu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40073/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 7:29 a.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-13733
> https://issues.apache.org/jira/browse/AMBARI-13733
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Adding checking selinux status mechanism on each host when creating new cluster.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/custom_actions/scripts/check_host.py 8b49725
> ambari-web/app/controllers/wizard/step3_controller.js cf1f1ae
> ambari-web/app/messages.js 78c439b
> ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 9c6454e
> ambari-web/app/views/wizard/step3_view.js 6ecfb41
> ambari-web/test/views/wizard/step3/hostWarningPopupBody_view_test.js 3cd53a0
>
> Diff: https://reviews.apache.org/r/40073/diff/
>
>
> Testing
> -------
>
> Manual testing done.
> ======
>
> Ambar-web
> mvn clean test
>
> 10080 tests complete (11 seconds)
> 105 tests pending
>
>
> Thanks,
>
> Mehmet Zahid Yuzuguldu
>
>
Re: Review Request 40073: Checking selinux status on each host when
creating new cluster
Posted by Mehmet Zahid Yuzuguldu <zy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40073/
-----------------------------------------------------------
(Updated Nov. 12, 2015, 7:29 a.m.)
Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
Bugs: AMBARI-13733
https://issues.apache.org/jira/browse/AMBARI-13733
Repository: ambari
Description
-------
Adding checking selinux status mechanism on each host when creating new cluster.
Diffs (updated)
-----
ambari-server/src/main/resources/custom_actions/scripts/check_host.py 8b49725
ambari-web/app/controllers/wizard/step3_controller.js cf1f1ae
ambari-web/app/messages.js 78c439b
ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 9c6454e
ambari-web/app/views/wizard/step3_view.js 6ecfb41
ambari-web/test/views/wizard/step3/hostWarningPopupBody_view_test.js 3cd53a0
Diff: https://reviews.apache.org/r/40073/diff/
Testing (updated)
-------
Manual testing done.
======
Ambar-web
mvn clean test
10080 tests complete (11 seconds)
105 tests pending
Thanks,
Mehmet Zahid Yuzuguldu