You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/03/18 05:03:46 UTC

Review Request: Added a more comprehensive slave recovery test to confirm that the restarted slave can communicate with scheduler, executor and master.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9992/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Ben Mahler.


Description
-------

Also cleaned up some slave recovery tests.


Diffs
-----

  src/sched/sched.cpp 960f68bfd6398dc08dc00b9b9ca55b9b2492114e 
  src/tests/slave_recovery_tests.cpp 63721c5befe212e1aa559bf5a6e7d34ffce28d4f 

Diff: https://reviews.apache.org/r/9992/diff/


Testing
-------

make check.


Thanks,

Vinod Kone


Re: Review Request: Added a more comprehensive slave recovery test to confirm that the restarted slave can communicate with scheduler, executor and master.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9992/#review18114
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On March 18, 2013, 4:03 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9992/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 4:03 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> Also cleaned up some slave recovery tests.
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp 960f68bfd6398dc08dc00b9b9ca55b9b2492114e 
>   src/tests/slave_recovery_tests.cpp 63721c5befe212e1aa559bf5a6e7d34ffce28d4f 
> 
> Diff: https://reviews.apache.org/r/9992/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request: Added a more comprehensive slave recovery test to confirm that the restarted slave can communicate with scheduler, executor and master.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9992/#review18136
-----------------------------------------------------------

Ship it!


nice test!


src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/9992/#comment38262>

    kill \n


- Ben Mahler


On March 18, 2013, 4:03 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9992/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 4:03 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> Also cleaned up some slave recovery tests.
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp 960f68bfd6398dc08dc00b9b9ca55b9b2492114e 
>   src/tests/slave_recovery_tests.cpp 63721c5befe212e1aa559bf5a6e7d34ffce28d4f 
> 
> Diff: https://reviews.apache.org/r/9992/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>