You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/02/19 01:36:47 UTC

[GitHub] [orc] autumnust commented on a change in pull request #637: ORC-747: Abstract Dictionary interface and refactoring

autumnust commented on a change in pull request #637:
URL: https://github.com/apache/orc/pull/637#discussion_r578864919



##########
File path: java/core/src/java/org/apache/orc/OrcConf.java
##########
@@ -105,6 +105,11 @@
           "(default 10000 rows) else dictionary check will happen before\n" +
           "writing first stripe. In both cases, the decision to use\n" +
           "dictionary or not will be retained thereafter."),
+  DICTIONARY_IMPL("orc.dictionary.implementation", null,

Review comment:
       the value for this config is being processed `createDict`. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org