[GitHub] [nifi] mark-bathori commented on a diff in pull request #7449: NIFI-11334: PutIceberg processor instance interference due same class loader usage

["mark-bathori (via GitHub)" <gi...@apache.org>]

mark-bathori commented on code in PR #7449:
URL: https://github.com/apache/nifi/pull/7449#discussion_r1248004762


##########
nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-services-api/src/main/java/org/apache/nifi/services/iceberg/IcebergCatalogProperties.java:
##########
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.services.iceberg;
+
+public class IcebergCatalogProperties {
+
+    public static final String METASTORE_URI = "metastoreUri";
+    public static final String WAREHOUSE_LOCATION = "warehouseLocation";

Review Comment:
   Yes the Enum is more suitable for this. Since the enum value will be used as the catalogProperty key the "icebergPropertyName" is not needed anymore.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org