You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/22 16:59:08 UTC
[GitHub] [spark] Kimahriman commented on pull request #32987: [SPARK-35564][SQL] Support subexpression elimination for conditionally evaluated expressions
Kimahriman commented on pull request #32987:
URL: https://github.com/apache/spark/pull/32987#issuecomment-866163907
> After this, any common expression shared between conditionally evaluated expression and a normal expression will be subexpression. I have a concern that gen-ed code will be overwhelmed with such subexpressions.
What exactly is the overwhelming part? I figured smaller overall code size would be beneficial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org