You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "RexXiong (via GitHub)" <gi...@apache.org> on 2023/09/15 08:48:10 UTC
[GitHub] [incubator-celeborn] RexXiong opened a new pull request, #1916: [CELEBORN-468] Timeout useless lostWorkers/shutdownWorkers meta
RexXiong opened a new pull request, #1916:
URL: https://github.com/apache/incubator-celeborn/pull/1916
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
As title
### Why are the changes needed?
If Worker lost or lost after graceful shutdown, Master would retain these lostWorker/shutdownWorkers meta permanently,
These meta would cause some noisy message in lifecycleManager. For these meta better to delete them after a while
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
UT & E2E test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1916: [CELEBORN-468] Timeout useless lostWorkers/shutdownWorkers meta
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on code in PR #1916:
URL: https://github.com/apache/incubator-celeborn/pull/1916#discussion_r1328448582
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java:
##########
@@ -135,6 +135,17 @@ public void updateWorkerRemoveMeta(
excludedWorkers.remove(worker);
}
+ public void removeWorkersUnavailableInfoMeta(List<WorkerInfo> unavailableWorkers) {
+ synchronized (workers) {
+ for (WorkerInfo workerInfo : unavailableWorkers) {
+ if (lostWorkers.containsKey(workerInfo)) {
+ lostWorkers.remove(workerInfo);
+ shutdownWorkers.remove(workerInfo);
Review Comment:
> `shutdownWorkers` do not necessarily overlap with `lostWorkers`. Need to check `shutdownWorkers` independently, or don't check contains at all.
Only those shutdownWorkers which also in lost workers need remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1916: [CELEBORN-468] Timeout useless lostWorkers/shutdownWorkers meta
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #1916:
URL: https://github.com/apache/incubator-celeborn/pull/1916#discussion_r1328342930
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java:
##########
@@ -135,6 +135,17 @@ public void updateWorkerRemoveMeta(
excludedWorkers.remove(worker);
}
+ public void removeWorkersUnavailableInfoMeta(List<WorkerInfo> unavailableWorkers) {
+ synchronized (workers) {
+ for (WorkerInfo workerInfo : unavailableWorkers) {
+ if (lostWorkers.containsKey(workerInfo)) {
+ lostWorkers.remove(workerInfo);
+ shutdownWorkers.remove(workerInfo);
Review Comment:
`shutdownWorkers` do not necessarily overlap with `lostWorkers`. Need to check `shutdownWorkers` independently, or don't check contains at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1916: [CELEBORN-468] Timeout useless lostWorkers/shutdownWorkers meta
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #1916:
URL: https://github.com/apache/incubator-celeborn/pull/1916#discussion_r1328035091
##########
common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala:
##########
@@ -360,6 +362,10 @@ object ControlMessages extends Logging {
.build()
}
+ case class RemoveWorkersUnavailableInfo(
Review Comment:
Currently it's preferred not to define case classes for control messages, use pbs instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1916: [CELEBORN-468] Timeout useless lostWorkers/shutdownWorkers meta
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on code in PR #1916:
URL: https://github.com/apache/incubator-celeborn/pull/1916#discussion_r1328448582
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java:
##########
@@ -135,6 +135,17 @@ public void updateWorkerRemoveMeta(
excludedWorkers.remove(worker);
}
+ public void removeWorkersUnavailableInfoMeta(List<WorkerInfo> unavailableWorkers) {
+ synchronized (workers) {
+ for (WorkerInfo workerInfo : unavailableWorkers) {
+ if (lostWorkers.containsKey(workerInfo)) {
+ lostWorkers.remove(workerInfo);
+ shutdownWorkers.remove(workerInfo);
Review Comment:
> `shutdownWorkers` do not necessarily overlap with `lostWorkers`. Need to check `shutdownWorkers` independently, or don't check contains at all.
Only those lost workers which also in shutdownWorkers need remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1916: [CELEBORN-468] Timeout useless lostWorkers/shutdownWorkers meta
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on code in PR #1916:
URL: https://github.com/apache/incubator-celeborn/pull/1916#discussion_r1328448582
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java:
##########
@@ -135,6 +135,17 @@ public void updateWorkerRemoveMeta(
excludedWorkers.remove(worker);
}
+ public void removeWorkersUnavailableInfoMeta(List<WorkerInfo> unavailableWorkers) {
+ synchronized (workers) {
+ for (WorkerInfo workerInfo : unavailableWorkers) {
+ if (lostWorkers.containsKey(workerInfo)) {
+ lostWorkers.remove(workerInfo);
+ shutdownWorkers.remove(workerInfo);
Review Comment:
> `shutdownWorkers` do not necessarily overlap with `lostWorkers`. Need to check `shutdownWorkers` independently, or don't check contains at all.
ShutdownWorkers may also in lost workers if the workers are finally lost, then need remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture closed pull request #1916: [CELEBORN-468] Timeout useless lostWorkers/shutdownWorkers meta
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #1916: [CELEBORN-468] Timeout useless lostWorkers/shutdownWorkers meta
URL: https://github.com/apache/incubator-celeborn/pull/1916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1916: [CELEBORN-468] Timeout useless lostWorkers/shutdownWorkers meta
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #1916:
URL: https://github.com/apache/incubator-celeborn/pull/1916#discussion_r1328536001
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java:
##########
@@ -135,6 +135,17 @@ public void updateWorkerRemoveMeta(
excludedWorkers.remove(worker);
}
+ public void removeWorkersUnavailableInfoMeta(List<WorkerInfo> unavailableWorkers) {
+ synchronized (workers) {
+ for (WorkerInfo workerInfo : unavailableWorkers) {
+ if (lostWorkers.containsKey(workerInfo)) {
+ lostWorkers.remove(workerInfo);
+ shutdownWorkers.remove(workerInfo);
Review Comment:
Right, thanks :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1916: [CELEBORN-468] Timeout useless lostWorkers/shutdownWorkers meta
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1916:
URL: https://github.com/apache/incubator-celeborn/pull/1916#issuecomment-1720948711
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1916?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1916](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1916?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6e1fed7) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/0bf42013f0c5b530e040f19a1c1305af5fd04c7a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0bf4201) will **increase** coverage by `0.04%`.
> Report is 5 commits behind head on main.
> The diff coverage is `29.17%`.
```diff
@@ Coverage Diff @@
## main #1916 +/- ##
==========================================
+ Coverage 46.51% 46.55% +0.04%
==========================================
Files 164 164
Lines 10228 10271 +43
Branches 936 939 +3
==========================================
+ Hits 4757 4781 +24
- Misses 5158 5176 +18
- Partials 313 314 +1
```
| [Files Changed](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...born/common/protocol/message/ControlMessages.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3Byb3RvY29sL21lc3NhZ2UvQ29udHJvbE1lc3NhZ2VzLnNjYWxh) | `1.52% <0.00%> (-0.03%)` | :arrow_down: |
| [...cala/org/apache/celeborn/common/CelebornConf.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL0NlbGVib3JuQ29uZi5zY2FsYQ==) | `87.45% <87.50%> (-0.03%)` | :arrow_down: |
... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1916/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org