You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Wing Yew Poon (Created) (JIRA)" <ji...@apache.org> on 2012/03/26 22:02:28 UTC
[jira] [Created] (ZOOKEEPER-1433) improve ZxidRolloverTest (test
seems flakey)
improve ZxidRolloverTest (test seems flakey)
--------------------------------------------
Key: ZOOKEEPER-1433
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1433
Project: ZooKeeper
Issue Type: Improvement
Components: tests
Affects Versions: 3.3.5
Reporter: Wing Yew Poon
Fix For: 3.3.5
In our jenkins job to run the ZooKeeper unit tests, org.apache.zookeeper.server.ZxidRolloverTest sometimes fails.
E.g.,
{noformat}
org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /foo0
at org.apache.zookeeper.KeeperException.create(KeeperException.java:90)
at org.apache.zookeeper.KeeperException.create(KeeperException.java:42)
at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:815)
at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:843)
at org.apache.zookeeper.server.ZxidRolloverTest.checkNodes(ZxidRolloverTest.java:154)
at org.apache.zookeeper.server.ZxidRolloverTest.testRolloverThenRestart(ZxidRolloverTest.java:211)
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1433) improve ZxidRolloverTest (test
seems flakey)
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240974#comment-13240974 ]
Hadoop QA commented on ZOOKEEPER-1433:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520365/ZOOKEEPER-1433.patch
against trunk revision 1302736.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1018//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1018//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1018//console
This message is automatically generated.
> improve ZxidRolloverTest (test seems flakey)
> --------------------------------------------
>
> Key: ZOOKEEPER-1433
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1433
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.5
> Reporter: Wing Yew Poon
> Assignee: Patrick Hunt
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1433.patch, ZOOKEEPER-1433_test.out
>
>
> In our jenkins job to run the ZooKeeper unit tests, org.apache.zookeeper.server.ZxidRolloverTest sometimes fails.
> E.g.,
> {noformat}
> org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /foo0
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:90)
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:42)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:815)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:843)
> at org.apache.zookeeper.server.ZxidRolloverTest.checkNodes(ZxidRolloverTest.java:154)
> at org.apache.zookeeper.server.ZxidRolloverTest.testRolloverThenRestart(ZxidRolloverTest.java:211)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1433) improve ZxidRolloverTest (test
seems flakey)
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242258#comment-13242258 ]
Hudson commented on ZOOKEEPER-1433:
-----------------------------------
Integrated in ZooKeeper-trunk #1512 (See [https://builds.apache.org/job/ZooKeeper-trunk/1512/])
ZOOKEEPER-1433. improve ZxidRolloverTest (test seems flakey) (phunt via henryr) (Revision 1307191)
Result = SUCCESS
henry : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307191
Files :
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/ZxidRolloverTest.java
> improve ZxidRolloverTest (test seems flakey)
> --------------------------------------------
>
> Key: ZOOKEEPER-1433
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1433
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.5
> Reporter: Wing Yew Poon
> Assignee: Patrick Hunt
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1433.patch, ZOOKEEPER-1433_test.out
>
>
> In our jenkins job to run the ZooKeeper unit tests, org.apache.zookeeper.server.ZxidRolloverTest sometimes fails.
> E.g.,
> {noformat}
> org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /foo0
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:90)
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:42)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:815)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:843)
> at org.apache.zookeeper.server.ZxidRolloverTest.checkNodes(ZxidRolloverTest.java:154)
> at org.apache.zookeeper.server.ZxidRolloverTest.testRolloverThenRestart(ZxidRolloverTest.java:211)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1433) improve ZxidRolloverTest (test
seems flakey)
Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241369#comment-13241369 ]
Patrick Hunt commented on ZOOKEEPER-1433:
-----------------------------------------
200 additional green runs overnight on this, looks solid.
> improve ZxidRolloverTest (test seems flakey)
> --------------------------------------------
>
> Key: ZOOKEEPER-1433
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1433
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.5
> Reporter: Wing Yew Poon
> Assignee: Patrick Hunt
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1433.patch, ZOOKEEPER-1433_test.out
>
>
> In our jenkins job to run the ZooKeeper unit tests, org.apache.zookeeper.server.ZxidRolloverTest sometimes fails.
> E.g.,
> {noformat}
> org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /foo0
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:90)
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:42)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:815)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:843)
> at org.apache.zookeeper.server.ZxidRolloverTest.checkNodes(ZxidRolloverTest.java:154)
> at org.apache.zookeeper.server.ZxidRolloverTest.testRolloverThenRestart(ZxidRolloverTest.java:211)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1433) improve ZxidRolloverTest (test
seems flakey)
Posted by "Henry Robinson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241973#comment-13241973 ]
Henry Robinson commented on ZOOKEEPER-1433:
-------------------------------------------
+1, looks good to me.
> improve ZxidRolloverTest (test seems flakey)
> --------------------------------------------
>
> Key: ZOOKEEPER-1433
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1433
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.5
> Reporter: Wing Yew Poon
> Assignee: Patrick Hunt
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1433.patch, ZOOKEEPER-1433_test.out
>
>
> In our jenkins job to run the ZooKeeper unit tests, org.apache.zookeeper.server.ZxidRolloverTest sometimes fails.
> E.g.,
> {noformat}
> org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /foo0
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:90)
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:42)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:815)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:843)
> at org.apache.zookeeper.server.ZxidRolloverTest.checkNodes(ZxidRolloverTest.java:154)
> at org.apache.zookeeper.server.ZxidRolloverTest.testRolloverThenRestart(ZxidRolloverTest.java:211)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1433) improve ZxidRolloverTest (test
seems flakey)
Posted by "Patrick Hunt (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-1433:
------------------------------------
Fix Version/s: (was: 3.3.5)
3.5.0
3.4.4
3.3.6
Assignee: Patrick Hunt
Looks like I missed checking that the clients disconnect, then reconnect after restarting the server. In some cases this doesn't happen fast enough and the exist check fails as a result (ie the client hasn't noticed that the server went down/came back).
> improve ZxidRolloverTest (test seems flakey)
> --------------------------------------------
>
> Key: ZOOKEEPER-1433
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1433
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.5
> Reporter: Wing Yew Poon
> Assignee: Patrick Hunt
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
>
> In our jenkins job to run the ZooKeeper unit tests, org.apache.zookeeper.server.ZxidRolloverTest sometimes fails.
> E.g.,
> {noformat}
> org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /foo0
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:90)
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:42)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:815)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:843)
> at org.apache.zookeeper.server.ZxidRolloverTest.checkNodes(ZxidRolloverTest.java:154)
> at org.apache.zookeeper.server.ZxidRolloverTest.testRolloverThenRestart(ZxidRolloverTest.java:211)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1433) improve ZxidRolloverTest (test
seems flakey)
Posted by "Wing Yew Poon (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wing Yew Poon updated ZOOKEEPER-1433:
-------------------------------------
Attachment: ZOOKEEPER-1433_test.out
stdout from test run.
> improve ZxidRolloverTest (test seems flakey)
> --------------------------------------------
>
> Key: ZOOKEEPER-1433
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1433
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.5
> Reporter: Wing Yew Poon
> Assignee: Patrick Hunt
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1433_test.out
>
>
> In our jenkins job to run the ZooKeeper unit tests, org.apache.zookeeper.server.ZxidRolloverTest sometimes fails.
> E.g.,
> {noformat}
> org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /foo0
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:90)
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:42)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:815)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:843)
> at org.apache.zookeeper.server.ZxidRolloverTest.checkNodes(ZxidRolloverTest.java:154)
> at org.apache.zookeeper.server.ZxidRolloverTest.testRolloverThenRestart(ZxidRolloverTest.java:211)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1433) improve ZxidRolloverTest (test
seems flakey)
Posted by "Patrick Hunt (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-1433:
------------------------------------
Attachment: ZOOKEEPER-1433.patch
This patch fixes the issue. Went from being able to reproduce the flakey test issue on particular hardware once every 10 runs to running more than 100 runs without seeing it again. Getting the client connection handling right turned out to be tricky.
> improve ZxidRolloverTest (test seems flakey)
> --------------------------------------------
>
> Key: ZOOKEEPER-1433
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1433
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.5
> Reporter: Wing Yew Poon
> Assignee: Patrick Hunt
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1433.patch, ZOOKEEPER-1433_test.out
>
>
> In our jenkins job to run the ZooKeeper unit tests, org.apache.zookeeper.server.ZxidRolloverTest sometimes fails.
> E.g.,
> {noformat}
> org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /foo0
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:90)
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:42)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:815)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:843)
> at org.apache.zookeeper.server.ZxidRolloverTest.checkNodes(ZxidRolloverTest.java:154)
> at org.apache.zookeeper.server.ZxidRolloverTest.testRolloverThenRestart(ZxidRolloverTest.java:211)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1433) improve ZxidRolloverTest (test
seems flakey)
Posted by "Mahadev konar (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241504#comment-13241504 ]
Mahadev konar commented on ZOOKEEPER-1433:
------------------------------------------
+1 looks good to me... Thanks for fixing this Pat!
> improve ZxidRolloverTest (test seems flakey)
> --------------------------------------------
>
> Key: ZOOKEEPER-1433
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1433
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.5
> Reporter: Wing Yew Poon
> Assignee: Patrick Hunt
> Fix For: 3.3.6, 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1433.patch, ZOOKEEPER-1433_test.out
>
>
> In our jenkins job to run the ZooKeeper unit tests, org.apache.zookeeper.server.ZxidRolloverTest sometimes fails.
> E.g.,
> {noformat}
> org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /foo0
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:90)
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:42)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:815)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:843)
> at org.apache.zookeeper.server.ZxidRolloverTest.checkNodes(ZxidRolloverTest.java:154)
> at org.apache.zookeeper.server.ZxidRolloverTest.testRolloverThenRestart(ZxidRolloverTest.java:211)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira