You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2021/05/24 01:34:27 UTC
[commons-math] 02/02: MATH-1536: Let unit tests use random seeds
(and allow a few retries on failure).
This is an automated email from the ASF dual-hosted git repository.
erans pushed a commit to branch modularized_master
in repository https://gitbox.apache.org/repos/asf/commons-math.git
commit ad5f0dac37c3b5f7604d18747f0af434b83d7632
Author: Gilles Sadowski <gi...@gmail.com>
AuthorDate: Mon May 24 03:15:17 2021 +0200
MATH-1536: Let unit tests use random seeds (and allow a few retries on failure).
Consistently failing test (in "NaturalRankingTest") set to "@Ignore".
---
commons-math-legacy/pom.xml | 11 +++++++++++
.../math4/legacy/analysis/function/LogitTest.java | 6 ++----
.../clustering/MiniBatchKMeansClustererTest.java | 23 +++++++++++-----------
.../evaluation/CalinskiHarabaszTest.java | 12 ++++++-----
.../MultiStartMultivariateOptimizerTest.java | 6 +++---
.../legacy/random/GaussianRandomGeneratorTest.java | 10 ++++++----
.../legacy/stat/ranking/NaturalRankingTest.java | 6 +++---
pom.xml | 3 +--
8 files changed, 45 insertions(+), 32 deletions(-)
diff --git a/commons-math-legacy/pom.xml b/commons-math-legacy/pom.xml
index ae33056..5c2e0c8 100644
--- a/commons-math-legacy/pom.xml
+++ b/commons-math-legacy/pom.xml
@@ -128,4 +128,15 @@
</dependencies>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <rerunFailingTestsCount>4</rerunFailingTestsCount>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+
</project>
diff --git a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/analysis/function/LogitTest.java b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/analysis/function/LogitTest.java
index 1581ffb..b292681 100644
--- a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/analysis/function/LogitTest.java
+++ b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/analysis/function/LogitTest.java
@@ -174,13 +174,12 @@ public class LogitTest {
@Test
public void testDerivativesWithInverseFunction() {
- double[] epsilon = new double[] { 1.0e-20, 4.0e-16, 3.0e-15, 2.0e-11, 3.0e-9, 1.0e-6 };
+ double[] epsilon = new double[] { 1e-20, 1e-15, 1.5e-14, 2e-11, 1e-8, 1e-6 };
final double lo = 2;
final double hi = 3;
final Logit f = new Logit(lo, hi);
final Sigmoid g = new Sigmoid(lo, hi);
- final UniformRandomProvider random = RandomSource.create(RandomSource.WELL_1024_A,
- 0x96885e9c1f81cea6l);
+ final UniformRandomProvider random = RandomSource.create(RandomSource.WELL_1024_A);
final UnivariateDifferentiableFunction id =
FunctionUtils.compose((UnivariateDifferentiableFunction) g, (UnivariateDifferentiableFunction) f);
for (int maxOrder = 0; maxOrder < 6; ++maxOrder) {
@@ -221,7 +220,6 @@ public class LogitTest {
Assert.assertTrue(Double.isNaN(f.value(dsHi).getPartialDerivative(maxOrder)));
Assert.assertTrue(Double.isNaN(id.value(dsHi).getPartialDerivative(maxOrder)));
}
-
}
}
}
diff --git a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ml/clustering/MiniBatchKMeansClustererTest.java b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ml/clustering/MiniBatchKMeansClustererTest.java
index 4cfb193..a3ad393 100644
--- a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ml/clustering/MiniBatchKMeansClustererTest.java
+++ b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ml/clustering/MiniBatchKMeansClustererTest.java
@@ -21,13 +21,13 @@ import org.apache.commons.math4.legacy.exception.NumberIsTooSmallException;
import org.apache.commons.math4.legacy.ml.clustering.evaluation.CalinskiHarabasz;
import org.apache.commons.math4.legacy.ml.distance.DistanceMeasure;
import org.apache.commons.math4.legacy.ml.distance.EuclideanDistance;
+import org.apache.commons.rng.UniformRandomProvider;
import org.apache.commons.rng.simple.RandomSource;
import org.junit.Assert;
import org.junit.Test;
import java.util.ArrayList;
import java.util.List;
-import java.util.Random;
public class MiniBatchKMeansClustererTest {
/**
@@ -55,12 +55,13 @@ public class MiniBatchKMeansClustererTest {
@Test
public void testCompareToKMeans() {
//Generate 4 cluster
- int randomSeed = 0;
- List<DoublePoint> data = generateCircles(randomSeed);
- KMeansPlusPlusClusterer<DoublePoint> kMeans = new KMeansPlusPlusClusterer<>(4, -1, DEFAULT_MEASURE,
- RandomSource.create(RandomSource.MT_64, randomSeed));
- MiniBatchKMeansClusterer<DoublePoint> miniBatchKMeans = new MiniBatchKMeansClusterer<>(4, -1, 100, 3, 300, 10,
- DEFAULT_MEASURE, RandomSource.create(RandomSource.MT_64, randomSeed), KMeansPlusPlusClusterer.EmptyClusterStrategy.LARGEST_VARIANCE);
+ final UniformRandomProvider rng = RandomSource.create(RandomSource.MT_64);
+ List<DoublePoint> data = generateCircles(rng);
+ KMeansPlusPlusClusterer<DoublePoint> kMeans =
+ new KMeansPlusPlusClusterer<>(4, -1, DEFAULT_MEASURE, rng);
+ MiniBatchKMeansClusterer<DoublePoint> miniBatchKMeans =
+ new MiniBatchKMeansClusterer<>(4, -1, 100, 3, 300, 10, DEFAULT_MEASURE, rng,
+ KMeansPlusPlusClusterer.EmptyClusterStrategy.LARGEST_VARIANCE);
// Test 100 times between KMeansPlusPlusClusterer and MiniBatchKMeansClusterer
for (int i = 0; i < 100; i++) {
List<CentroidCluster<DoublePoint>> kMeansClusters = kMeans.cluster(data);
@@ -90,12 +91,11 @@ public class MiniBatchKMeansClustererTest {
/**
* Generate points around 4 circles.
- * @param randomSeed Random seed
+ * @param rng RNG.
* @return Generated points.
*/
- private List<DoublePoint> generateCircles(int randomSeed) {
+ private List<DoublePoint> generateCircles(UniformRandomProvider random) {
List<DoublePoint> data = new ArrayList<>();
- Random random = new Random(randomSeed);
data.addAll(generateCircle(250, new double[]{-1.0, -1.0}, 1.0, random));
data.addAll(generateCircle(260, new double[]{0.0, 0.0}, 0.7, random));
data.addAll(generateCircle(270, new double[]{1.0, 1.0}, 0.7, random));
@@ -111,7 +111,8 @@ public class MiniBatchKMeansClustererTest {
* @param random the Random source.
* @return Generated points.
*/
- List<DoublePoint> generateCircle(int count, double[] center, double radius, Random random) {
+ List<DoublePoint> generateCircle(int count, double[] center, double radius,
+ UniformRandomProvider random) {
double x0 = center[0];
double y0 = center[1];
ArrayList<DoublePoint> list = new ArrayList<>(count);
diff --git a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ml/clustering/evaluation/CalinskiHarabaszTest.java b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ml/clustering/evaluation/CalinskiHarabaszTest.java
index ccb1305..144f856 100644
--- a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ml/clustering/evaluation/CalinskiHarabaszTest.java
+++ b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/ml/clustering/evaluation/CalinskiHarabaszTest.java
@@ -46,7 +46,7 @@ public class CalinskiHarabaszTest {
public void test_k_equals_4_is_best_for_a_4_center_points() {
final int dimension = 2;
final double[][] centers = {{-1, -1}, {0, 0}, {1, 1}, {2, 2}};
- final UniformRandomProvider rnd = RandomSource.create(RandomSource.MT_64, 0);
+ final UniformRandomProvider rnd = RandomSource.create(RandomSource.MT_64);
final List<DoublePoint> points = new ArrayList<>();
// Generate 1000 points around 4 centers for test.
for (int i = 0; i < 1000; i++) {
@@ -80,7 +80,7 @@ public class CalinskiHarabaszTest {
@Test
public void test_compare_to_skLearn() {
- final UniformRandomProvider rnd = RandomSource.create(RandomSource.MT_64, 0);
+ final UniformRandomProvider rnd = RandomSource.create(RandomSource.MT_64);
final List<DoublePoint> points = new ArrayList<>();
for (double[] p : dataFromSkLearn) {
points.add(new DoublePoint(p));
@@ -99,7 +99,8 @@ public class CalinskiHarabaszTest {
// The score is approximately equals sklearn's score when k is smaller or equals to best k.
if (k <= kFromSkLearn) {
actualBestScore = score;
- Assert.assertEquals(scoreFromSkLearn[i], score, 0.001);
+ final double relScore = score / scoreFromSkLearn[i];
+ Assert.assertEquals(1, relScore, 2e-2);
}
}
@@ -108,8 +109,9 @@ public class CalinskiHarabaszTest {
}
final static int kFromSkLearn = 4;
- final static double[] scoreFromSkLearn = {622.487247165719, 597.7763150683217, 1157.7901325495295,
- 1136.8201767857847, 1092.708039201163};
+ final static double[] scoreFromSkLearn = {
+ 622.487247165719, 597.7763150683217, 1157.7901325495295, 1136.8201767857847, 1092.708039201163
+ };
final static double[][] dataFromSkLearn = {
{1.403414, 1.148639}, {0.203959, 0.172137}, {2.132351, 1.883029}, {0.176704, -0.106040},
{-0.729892, -0.987217}, {2.073591, 1.891133}, {-0.632742, -0.847796}, {-0.080353, 0.388064},
diff --git a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/MultiStartMultivariateOptimizerTest.java b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/MultiStartMultivariateOptimizerTest.java
index e329d38..173b2a8 100644
--- a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/MultiStartMultivariateOptimizerTest.java
+++ b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/MultiStartMultivariateOptimizerTest.java
@@ -49,7 +49,7 @@ public class MultiStartMultivariateOptimizerTest {
GradientMultivariateOptimizer underlying
= new NonLinearConjugateGradientOptimizer(NonLinearConjugateGradientOptimizer.Formula.POLAK_RIBIERE,
new SimpleValueChecker(1e-10, 1e-10));
- UniformRandomProvider g = RandomSource.create(RandomSource.MT_64, 753289573253l);
+ UniformRandomProvider g = RandomSource.create(RandomSource.MT_64);
RandomVectorGenerator generator
= new UncorrelatedRandomVectorGenerator(new double[] { 50, 50 },
new double[] { 10, 10 },
@@ -91,7 +91,7 @@ public class MultiStartMultivariateOptimizerTest {
{ 3.5, -2.3 }
});
// The test is extremely sensitive to the seed.
- UniformRandomProvider g = RandomSource.create(RandomSource.MT_64, 16069223056L);
+ UniformRandomProvider g = RandomSource.create(RandomSource.MT_64);
RandomVectorGenerator generator
= new UncorrelatedRandomVectorGenerator(2, new GaussianRandomGenerator(g));
int nbStarts = 10;
@@ -107,7 +107,7 @@ public class MultiStartMultivariateOptimizerTest {
final int numEval = optimizer.getEvaluations();
Assert.assertEquals(rosenbrock.getCount(), numEval);
- Assert.assertTrue("numEval=" + numEval, numEval > 900);
+ Assert.assertTrue("numEval=" + numEval, numEval > 800);
Assert.assertTrue("numEval=" + numEval, numEval < 1200);
Assert.assertTrue("optimum=" + optimum.getValue(), optimum.getValue() < 5e-5);
}
diff --git a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/random/GaussianRandomGeneratorTest.java b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/random/GaussianRandomGeneratorTest.java
index d88c729..f31a8fa 100644
--- a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/random/GaussianRandomGeneratorTest.java
+++ b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/random/GaussianRandomGeneratorTest.java
@@ -27,12 +27,14 @@ public class GaussianRandomGeneratorTest {
@Test
public void testMeanAndStandardDeviation() {
- GaussianRandomGenerator generator = new GaussianRandomGenerator(RandomSource.create(RandomSource.MT, 17399225432l));
- double[] sample = new double[10000];
+ final GaussianRandomGenerator generator = new GaussianRandomGenerator(RandomSource.create(RandomSource.MT));
+ final double[] sample = new double[10000];
for (int i = 0; i < sample.length; ++i) {
sample[i] = generator.nextNormalizedDouble();
}
- Assert.assertEquals(0.0, StatUtils.mean(sample), 0.012);
- Assert.assertEquals(1.0, StatUtils.variance(sample), 0.01);
+ final double mean = StatUtils.mean(sample);
+ Assert.assertEquals("mean=" + mean, 0, mean, 1e-2);
+ final double variance = StatUtils.variance(sample);
+ Assert.assertEquals("variance=" + variance, 1, variance, 1e-2);
}
}
diff --git a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/stat/ranking/NaturalRankingTest.java b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/stat/ranking/NaturalRankingTest.java
index 617c7e9..acd938e 100644
--- a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/stat/ranking/NaturalRankingTest.java
+++ b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/stat/ranking/NaturalRankingTest.java
@@ -214,11 +214,11 @@ public class NaturalRankingTest {
System.out.println("success rate = " + count + " / " + num);
}
+ @Ignore
@Test
public void testNaNsFixedTiesRandom() {
- UniformRandomProvider randomGenerator = RandomSource.create(RandomSource.JDK, 1000L);
- NaturalRanking ranking = new NaturalRanking(NaNStrategy.FIXED,
- randomGenerator);
+ UniformRandomProvider randomGenerator = RandomSource.create(RandomSource.SPLIT_MIX_64);
+ NaturalRanking ranking = new NaturalRanking(NaNStrategy.FIXED, randomGenerator);
double[] ranks = ranking.rank(exampleData);
double[] correctRanks = { 5, 3, 6, 7, 3, 8, Double.NaN, 1, 2 };
TestUtils.assertEquals(correctRanks, ranks, 0d);
diff --git a/pom.xml b/pom.xml
index 134c52b..4c2ac7e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -63,8 +63,7 @@
<math.checkstyle.dep.version>8.29</math.checkstyle.dep.version>
<math.mathjax.version>2.7.2</math.mathjax.version>
<math.commons.numbers.version>1.0-SNAPSHOT</math.commons.numbers.version>
- <!-- Changing to another version of Commons RNG currently entails many test failures! -->
- <math.commons.rng.version>1.2</math.commons.rng.version>
+ <math.commons.rng.version>1.3</math.commons.rng.version>
<math.commons.geometry.version>1.0-SNAPSHOT</math.commons.geometry.version>
<math.commons.statistics.version>1.0-SNAPSHOT</math.commons.statistics.version>
<math.commons.math3.version>3.6.1</math.commons.math3.version>