You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2017/08/10 14:29:02 UTC

[GitHub] spark pull request #18488: [SPARK-21255][SQL][WIP] Fixed NPE when creating e...

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18488#discussion_r132468980
  
    --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionInfo.java ---
    @@ -79,7 +79,7 @@ public ExpressionInfo(
             assert name != null;
             assert arguments != null;
             assert examples != null;
    -        assert examples.isEmpty() || examples.startsWith("\n    Examples:");
    +        assert examples.isEmpty() || examples.startsWith(System.lineSeparator() + "    Examples:");
    --- End diff --
    
    I guess this one is not related?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org