You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/23 12:35:01 UTC
[GitHub] [hudi] yuzhaojing opened a new pull request, #5946: [HUDI-4297] Incre timeout for flaky test
yuzhaojing opened a new pull request, #5946:
URL: https://github.com/apache/hudi/pull/5946
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua closed pull request #5946: [HUDI-4297] Incre timeout for flaky test
Posted by GitBox <gi...@apache.org>.
yihua closed pull request #5946: [HUDI-4297] Incre timeout for flaky test
URL: https://github.com/apache/hudi/pull/5946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5946: [HUDI-4297] Incre timeout for flaky test
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5946:
URL: https://github.com/apache/hudi/pull/5946#issuecomment-1164360638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55daa5e62d17ade0b0f4a6aa4b3aafd7beeaae88",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9472",
"triggerID" : "55daa5e62d17ade0b0f4a6aa4b3aafd7beeaae88",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 55daa5e62d17ade0b0f4a6aa4b3aafd7beeaae88 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9472)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yuzhaojing commented on a diff in pull request #5946: [HUDI-4297] Incre timeout for flaky test
Posted by GitBox <gi...@apache.org>.
yuzhaojing commented on code in PR #5946:
URL: https://github.com/apache/hudi/pull/5946#discussion_r904983454
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieDeltaStreamer.java:
##########
@@ -796,7 +796,7 @@ static void deltaStreamerTestRunner(HoodieDeltaStreamer ds, HoodieDeltaStreamer.
throw new RuntimeException(ex.getMessage(), ex);
}
});
- TestHelpers.waitTillCondition(condition, dsFuture, 360);
+ TestHelpers.waitTillCondition(condition, dsFuture, 720);
Review Comment:
TestHoodieDeltaStreamerWithMultiWriter.testUpsertsContinuousModeWithMultipleWritersWithoutConflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5946: [HUDI-4297] Incre timeout for flaky test
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5946:
URL: https://github.com/apache/hudi/pull/5946#issuecomment-1164356150
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55daa5e62d17ade0b0f4a6aa4b3aafd7beeaae88",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "55daa5e62d17ade0b0f4a6aa4b3aafd7beeaae88",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 55daa5e62d17ade0b0f4a6aa4b3aafd7beeaae88 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #5946: [HUDI-4297] Incre timeout for flaky test
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #5946:
URL: https://github.com/apache/hudi/pull/5946#issuecomment-1164631733
Do we know increasing the timeout will fix the issue? I tried to reproduce locally. ran it for 100 times for both COW and MOR, but got it to fail only 2 times for MOR. Mostly I hit the issue where 2999 records were consumed out of 3000. I am not sure if increasing the timeout will actually solve the issue. my hunch is, may be some duplicate is generated and so there were only 2999 unique records. this is just a theory, but I need to investigate further to confirm my understanding.
but in the mean time, trying to understand whats your findings from the investigation. Whats the core stacktrace that you saw. @yuzhaojing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #5946: [HUDI-4297] Incre timeout for flaky test
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #5946:
URL: https://github.com/apache/hudi/pull/5946#discussion_r904980899
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieDeltaStreamer.java:
##########
@@ -796,7 +796,7 @@ static void deltaStreamerTestRunner(HoodieDeltaStreamer ds, HoodieDeltaStreamer.
throw new RuntimeException(ex.getMessage(), ex);
}
});
- TestHelpers.waitTillCondition(condition, dsFuture, 360);
+ TestHelpers.waitTillCondition(condition, dsFuture, 720);
Review Comment:
Which test case does it fix ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5946: [HUDI-4297] Incre timeout for flaky test
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5946:
URL: https://github.com/apache/hudi/pull/5946#issuecomment-1164563898
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55daa5e62d17ade0b0f4a6aa4b3aafd7beeaae88",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9472",
"triggerID" : "55daa5e62d17ade0b0f4a6aa4b3aafd7beeaae88",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 55daa5e62d17ade0b0f4a6aa4b3aafd7beeaae88 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9472)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yuzhaojing commented on pull request #5946: [HUDI-4297] Incre timeout for flaky test
Posted by GitBox <gi...@apache.org>.
yuzhaojing commented on PR #5946:
URL: https://github.com/apache/hudi/pull/5946#issuecomment-1168769869
I'm not sure if duplicates are generated, but after I increased the timeout parameter, it ran more than 50 times without failure. I will continue to investigate whether duplicates are generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on pull request #5946: [HUDI-4297] Incre timeout for flaky test
Posted by GitBox <gi...@apache.org>.
yihua commented on PR #5946:
URL: https://github.com/apache/hudi/pull/5946#issuecomment-1244740363
After a few fixes addressing flaky tests are landed on master, Azure CI is fairly stable and I think this is no longer needed. Closing this now. @yuzhaojing Feel free to reopen this PR if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org