You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eagle.apache.org by "Jayesh (JIRA)" <ji...@apache.org> on 2017/04/17 08:08:41 UTC

[jira] [Commented] (EAGLE-984) Potential null dereference in SimpleWindowCounter#poll()

    [ https://issues.apache.org/jira/browse/EAGLE-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970828#comment-15970828 ] 

Jayesh commented on EAGLE-984:
------------------------------

[~ted_yu] would you be interested in providing fix for this ?

> Potential null dereference in SimpleWindowCounter#poll()
> --------------------------------------------------------
>
>                 Key: EAGLE-984
>                 URL: https://issues.apache.org/jira/browse/EAGLE-984
>             Project: Eagle
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>             Fix For: v0.5.0
>
>
> Here is related code:
> {code}
>     public Tuple2<Long, Long> poll() {
>         long oldestTimestamp = timeQueue.poll();
>         Tuple2<Long, Long> pair = new Tuple2<>(oldestTimestamp, counter.get(oldestTimestamp));
> {code}
> We should check the return value from timeQueue.poll() before casting to long.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)