You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/01 21:56:54 UTC

[GitHub] [tvm] vinx13 commented on a change in pull request #8866: Set default value of p in LpPool as 2

vinx13 commented on a change in pull request #8866:
URL: https://github.com/apache/tvm/pull/8866#discussion_r700600990



##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -945,7 +945,7 @@ def _impl_v1(cls, inputs, attr, params):
         else:
             attr["layout"] = onnx_default_layout(dims=(len(input_shape) - 2), op_name="LpPool")
 
-        p = _expr.const(attr["p"], dtype)
+        p = _expr.const(attr.get("p", 2), dtype)
         reci_p = _expr.const(1.0 / attr["p"], dtype)

Review comment:
       oh I didn't spot it, please also add default value for this 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org