You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/12 03:42:10 UTC

[GitHub] [flink] leonardBang commented on a change in pull request #14610: [FLINK-20909][table-planner-blink] Fix deduplicate mini-batch interval infer

leonardBang commented on a change in pull request #14610:
URL: https://github.com/apache/flink/pull/14610#discussion_r555490717



##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/DeduplicateITCase.scala
##########
@@ -226,6 +226,42 @@ class DeduplicateITCase(miniBatch: MiniBatchMode, mode: StateBackendMode)
     assertEquals(expected.sorted, rawResult.sorted)
   }
 
+  @Test
+  def testLastRowOnRowTimeFollowedByUnboundedAgg(): Unit = {

Review comment:
       we should enable  `minibatch` here ? and we can also add a test for firstRow 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org