You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2025/11/05 12:27:27 UTC
[I] Browser's back button incorrectly implemented in dashboards [superset]
michael-s-molina opened a new issue, #36000:
URL: https://github.com/apache/superset/issues/36000
### Bug description
To go back to the dashboard list from a dashboard, the user needs to click twice on the browser's back button. The reason is because the `native_filters_key` is being added to the history stack instead of replacing the last entry.
### Screenshots/recordings
https://github.com/user-attachments/assets/27eef6f6-bf66-4f83-977e-0a47e70a2e16
### Superset version
master / latest-dev
### Python version
3.9
### Node version
16
### Browser
Chrome
### Additional context
_No response_
### Checklist
- [x] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [x] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [x] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Browser's back button incorrectly implemented in dashboards [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina closed issue #36000: Browser's back button incorrectly implemented in dashboards
URL: https://github.com/apache/superset/issues/36000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Browser's back button incorrectly implemented in dashboards [superset]
Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #36000:
URL: https://github.com/apache/superset/issues/36000#issuecomment-3490957974
<!-- Answer -->
The dashboard's native filter state is managed in the FilterBar component, which updates the URL with the `native_filters_key` using `history.replace`—not `pushState`—so it should replace the last history entry rather than add a new one. This logic is here: [FilterBar/index.tsx](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx#L80-L140). The function only calls `history.replace` when on a dashboard route, aiming to keep React Router and browser history in sync and avoid race conditions.
Despite this, the behavior you describe (needing to click back twice) suggests there may be an unexpected interaction or race condition elsewhere in the navigation or filter update flow. There are no recent changes or known issues in the codebase or support threads that directly address this, but the current implementation is intended to avoid adding extra history entries when updating `native_filters_key` in the URL.
<!-- Dosu Comment Footer -->
*To reply, just mention [@dosu](https://go.dosu.dev/dosubot).*
---
<sup>How did I do? [Good](https://app.dosu.dev/response-feedback/c2c3c8c5-66da-4e76-beb5-2586dc460dc0?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/c2c3c8c5-66da-4e76-beb5-2586dc460dc0?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/c2c3c8c5-66da-4e76-beb5-2586dc460dc0?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/c2c3c8c5-66da-4e76-beb5-2586dc460dc0?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/c2c3c8c5-66da-4e76-beb5-2586dc460dc0?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/c2c3c8c5-66da-4e76-beb5-2586dc460dc0?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/c2c3c8c5-66da-4e76-beb5-2586dc460dc0?feedback_type=other)</sup> [](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=githu
b) [](https://go.dosu.dev/discord-bot) [](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/36000)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Browser's back button incorrectly implemented in dashboards [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on issue #36000:
URL: https://github.com/apache/superset/issues/36000#issuecomment-3534991023
@michael-s-molina spun this up on the master branch, not seeing this behavior either: http://44.255.24.244:8080/superset/welcome/. Wondering if we can close out or if it's already been fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Browser's back button incorrectly implemented in dashboards [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on issue #36000:
URL: https://github.com/apache/superset/issues/36000#issuecomment-3522966004
@sadpandajoe Maybe it's only affecting master then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Browser's back button incorrectly implemented in dashboards [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on issue #36000:
URL: https://github.com/apache/superset/issues/36000#issuecomment-3505418773
@michael-s-molina can't seem to repro this on the 6.0 ephemeral here: http://34.222.127.13:8080/superset/welcome/
Test cases:
1. From the homepage select a dashboard with native filters
2. Click the back button after the dashboard loads
Result: Taken back to the homepage
1. From the dashboard list page select a dashboard with native filters
2. Click the back button after the dashboard loads
Result: Taken back to the dashboard list page
1. From the dashboard list page select a dashboard with native filters
2. Update native filter and apply
3. Click the back button after the dashboard loads
Result: Taken back to the dashboard list page
1. Go to the dashboard list page
2. Paste a url with an updated native filter
3. Click the back button after the dashboard loads
Result: Taken back to the dashboard list page
https://github.com/user-attachments/assets/eebef823-9d23-4df1-9653-7861fdd634de
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Browser's back button incorrectly implemented in dashboards [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on issue #36000:
URL: https://github.com/apache/superset/issues/36000#issuecomment-3571656802
It might have been fixed then. Thanks for checking @sadpandajoe!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org