You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "eugenegujing (via GitHub)" <gi...@apache.org> on 2026/07/15 22:47:41 UTC
[I] add unit test coverage for DatasetFileDocument URI parsing [texera]
eugenegujing opened a new issue, #6441:
URL: https://github.com/apache/texera/issues/6441
### Task Summary
`common/workflow-core/src/main/scala/org/apache/texera/amber/core/storage/model/DatasetFileDocument.scala` parses a dataset file URI in its constructor into a repository name, a URL-decoded version hash, and a URL-decoded multi-segment relative file path, rejecting URIs with fewer than three path segments with `IllegalArgumentException("URI format is incorrect")`.
Every dataset file read in the engine goes through this parsing, yet the class has zero references in the test tree — neither the parsing and its error path nor the parsed-component getters (`getRepositoryName`, `getVersionHash`, `getFileRelativePath`, `getURI`) are covered anywhere.
Note this is distinct from the existing Python-side tests (#4701 / #4702 cover `pytexera/storage/dataset_file_document.py`, a separate class). On the Scala side, #5699 added specs for the storage result models but did not touch `DatasetFileDocument`, and the existing `FileResolverSpec` covers the URI **construction** side only — the parsing side tested here is its complement.
### Task Type
- [ ] Refactor / Cleanup
- [ ] DevOps / Deployment / CI
- [x] Testing / QA
- [ ] Documentation
- [ ] Performance
- [ ] Other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] add unit test coverage for DatasetFileDocument URI parsing [texera]
Posted by "eugenegujing (via GitHub)" <gi...@apache.org>.
eugenegujing commented on issue #6441:
URL: https://github.com/apache/texera/issues/6441#issuecomment-4986015357
/take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] add unit test coverage for DatasetFileDocument URI parsing [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan closed issue #6441: add unit test coverage for DatasetFileDocument URI parsing
URL: https://github.com/apache/texera/issues/6441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org