You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/29 07:57:38 UTC
[GitHub] [incubator-nuttx-apps] no1wudi opened a new pull request #1107: system/libuv: Support specify stack size for worker thread
no1wudi opened a new pull request #1107:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1107
## Summary
Add a new option to configure stack size of worker thread in thread pool
## Impact
libuv only
## Testing
VELA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #1107: system/libuv: Support specify stack size for worker thread
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #1107:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1107#discussion_r837229499
##########
File path: system/libuv/0001-libuv-port-for-nuttx.patch
##########
@@ -169,7 +169,24 @@ index 869ae95f..8fabeba5 100644
}
-@@ -212,7 +217,7 @@ static void init_threads(void) {
+@@ -188,6 +193,16 @@ static void init_threads(void) {
+ const char* val;
+ uv_sem_t sem;
+
++ const uv_thread_options_t params = {
++#ifdef DEF_THREADPOOL_STACKSIZE
Review comment:
Seems like `DEF_THREADPOOL_STACKSIZE` is always defined, so why do we need to have `ifdef` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1107: system/libuv: Support specify stack size for worker thread
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1107:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1107#discussion_r837244980
##########
File path: system/libuv/0001-libuv-port-for-nuttx.patch
##########
@@ -169,7 +169,24 @@ index 869ae95f..8fabeba5 100644
}
-@@ -212,7 +217,7 @@ static void init_threads(void) {
+@@ -188,6 +193,16 @@ static void init_threads(void) {
+ const char* val;
+ uv_sem_t sem;
+
++ const uv_thread_options_t params = {
++#ifdef DEF_THREADPOOL_STACKSIZE
Review comment:
We need ensure the same code still can built on other platform and with the same result. And we plan to upstream the change to libuv community to reduce our maintain effort, so it's important to make the change as general as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1107: system/libuv: Support specify stack size for worker thread
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged pull request #1107:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1107: system/libuv: Support specify stack size for worker thread
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1107:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1107#discussion_r837244980
##########
File path: system/libuv/0001-libuv-port-for-nuttx.patch
##########
@@ -169,7 +169,24 @@ index 869ae95f..8fabeba5 100644
}
-@@ -212,7 +217,7 @@ static void init_threads(void) {
+@@ -188,6 +193,16 @@ static void init_threads(void) {
+ const char* val;
+ uv_sem_t sem;
+
++ const uv_thread_options_t params = {
++#ifdef DEF_THREADPOOL_STACKSIZE
Review comment:
We need ensure the same code still can built on other platform and with the same result. And we plan to upstream the change to libuv community, so it's important to make the change as general as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] no1wudi commented on a change in pull request #1107: system/libuv: Support specify stack size for worker thread
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #1107:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1107#discussion_r837231127
##########
File path: system/libuv/0001-libuv-port-for-nuttx.patch
##########
@@ -169,7 +169,24 @@ index 869ae95f..8fabeba5 100644
}
-@@ -212,7 +217,7 @@ static void init_threads(void) {
+@@ -188,6 +193,16 @@ static void init_threads(void) {
+ const char* val;
+ uv_sem_t sem;
+
++ const uv_thread_options_t params = {
++#ifdef DEF_THREADPOOL_STACKSIZE
Review comment:
It's defined on NuttX but not on all other platforms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1107: system/libuv: Support specify stack size for worker thread
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1107:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1107#discussion_r837244980
##########
File path: system/libuv/0001-libuv-port-for-nuttx.patch
##########
@@ -169,7 +169,24 @@ index 869ae95f..8fabeba5 100644
}
-@@ -212,7 +217,7 @@ static void init_threads(void) {
+@@ -188,6 +193,16 @@ static void init_threads(void) {
+ const char* val;
+ uv_sem_t sem;
+
++ const uv_thread_options_t params = {
++#ifdef DEF_THREADPOOL_STACKSIZE
Review comment:
We need ensure the same code still can built on other platform and with the result. And we plan to upstream the change to libuv community, so it's important to make the change as general as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #1107: system/libuv: Support specify stack size for worker thread
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #1107:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1107#discussion_r837235277
##########
File path: system/libuv/0001-libuv-port-for-nuttx.patch
##########
@@ -169,7 +169,24 @@ index 869ae95f..8fabeba5 100644
}
-@@ -212,7 +217,7 @@ static void init_threads(void) {
+@@ -188,6 +193,16 @@ static void init_threads(void) {
+ const char* val;
+ uv_sem_t sem;
+
++ const uv_thread_options_t params = {
++#ifdef DEF_THREADPOOL_STACKSIZE
Review comment:
yes, but this patch is to build the code with NuttX and not with other platforms :)
Anyway it is minor, so we can leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #1107: system/libuv: Support specify stack size for worker thread
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #1107:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1107#discussion_r837248014
##########
File path: system/libuv/0001-libuv-port-for-nuttx.patch
##########
@@ -169,7 +169,24 @@ index 869ae95f..8fabeba5 100644
}
-@@ -212,7 +217,7 @@ static void init_threads(void) {
+@@ -188,6 +193,16 @@ static void init_threads(void) {
+ const char* val;
+ uv_sem_t sem;
+
++ const uv_thread_options_t params = {
++#ifdef DEF_THREADPOOL_STACKSIZE
++ UV_THREAD_HAS_STACK_SIZE,
++ CONFIG_LIBUV_THREAD_STACKSIZE
Review comment:
@xiaoxiang781216 following the comment above let's apply this change then
```suggestion
+ DEF_THREADPOOL_STACKSIZE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org