You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Sean Busbey (JIRA)" <ji...@apache.org> on 2018/06/12 01:55:00 UTC

[jira] [Comment Edited] (HBASE-20334) add a test that expressly uses both our shaded client and the one from hadoop 3

    [ https://issues.apache.org/jira/browse/HBASE-20334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509064#comment-16509064 ] 

Sean Busbey edited comment on HBASE-20334 at 6/12/18 1:54 AM:
--------------------------------------------------------------

{quote}
-1	whitespace	0m 0s	The patch has 29 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1	whitespace	0m 1s	The patch 48 line(s) with tabs.
{quote}

The tabs are all in the TSV file used in the test. all but one of the whitespace instances is also. the last one is an error in the commit for  HBASE-20333 that I'll fix either on commit or if that jira needs another patch.


was (Author: busbey):
{quote}
-1	whitespace	0m 0s	The patch has 29 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1	whitespace	0m 1s	The patch 48 line(s) with tabs.
{quote}

The tabas are all in the TSV file used in the test. all but one of the whitespace instances is also. the last one is an error in the commit for  HBASE-20333 that I'll fix either on commit or if that jira needs another patch.

> add a test that expressly uses both our shaded client and the one from hadoop 3
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-20334
>                 URL: https://issues.apache.org/jira/browse/HBASE-20334
>             Project: HBase
>          Issue Type: Sub-task
>          Components: hadoop3, shading
>    Affects Versions: 2.0.0
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Major
>         Attachments: HBASE-20334.0.patch, HBASE-20334.1.patch
>
>
> Since we're making a shaded client that bleed out of our namespace and into Hadoop's, we should ensure that we can show our clients coexisting. Even if it's just an IT that successfully talks to both us and HDFS via our respective shaded clients, that'd be a big help in keeping us proactive.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)