[jira] Updated: (IVYDE-68) IvyDE is using some internal classes of Eclipse

["Nicolas Lalevée (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IVYDE-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Lalevée updated IVYDE-68:
---------------------------------

    Attachment: IVYDE-68-r617088.patch

Here is a patch that resolve the use of interla eclipse classes in IvyClasspathContainer. It has been taken from the patch of IVYDE-43 :
{noformat}
-                    JavaModelManager manager = JavaModelManager.getJavaModelManager();
-                    manager.containerPut(_javaProject, _path, null);
+//   EG:                 JavaModelManager manager = JavaModelManager.getJavaModelManager();
+//   EG:                 manager.containerPut(_javaProject, _path, null);
+                    // EG: Do not clear the container - let the model manager compare new container with the old and decide if it's changing 
                     JavaCore.setClasspathContainer(
                             _path,
                             new IJavaProject[] {_javaProject},
-                            new IClasspathContainer[] {IvyClasspathContainer.this},
+                            new IClasspathContainer[] {new IvyClasspathContainer(IvyClasspathContainer.this)},
                             null);
{noformat}
I tested locally, it works correctly.

> IvyDE is using some internal classes of Eclipse
> -----------------------------------------------
>
>                 Key: IVYDE-68
>                 URL: https://issues.apache.org/jira/browse/IVYDE-68
>             Project: IvyDE
>          Issue Type: Bug
>    Affects Versions: 1.3.0
>            Reporter: Nicolas Lalevée
>         Attachments: IVYDE-68-r607532.patch, IVYDE-68-r617088.patch, ivyde.diff
>
>
> Some classes in IvyDE use come classes which are in some {{org.eclipse....internal... }} packages, which should not be used. Compiling IvyDE with Eclipse 3.3 raise warning like :
> {quote}
> Discouraged access: The method containerPut(IJavaProject, IPath, IClasspathContainer) from the type JavaModelManager is not accessible due to restriction on required library /Users/nicolas/tools/eclipse-3.3/plugins/org.eclipse.jdt.core_3.3.1.v_780_R33x.jar	ivyde/src/java/org/apache/ivyde/eclipse/cpcontainer	IvyClasspathContainer.java	{quote}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.