You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by "kinow (via GitHub)" <gi...@apache.org> on 2024/03/27 10:46:57 UTC
[PR] GH-2370: Add tooltip to progress bars (via title attr) [jena]
kinow opened a new pull request, #2372:
URL: https://github.com/apache/jena/pull/2372
GitHub issue resolved #2370
Pull request Description:
Adds tooltips in case you have very long list and the text is not visible in the progress bars.
Here's a preview of the tooltip (dark tooltip, over one of the progress bars, mouse pointer not displayed).
----
- [ ] Tests are included.
- [ ] Documentation change and updates are provided for the [Apache Jena website](https://github.com/apache/jena-site/)
- [x] Commits have been squashed to remove intermediate development commit messages.
- [x] Key commit messages start with the issue number (GH-xxxx)
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
----
See the [Apache Jena "Contributing" guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] GH-2371: Add tooltip to progress bars (via title attr) [jena]
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #2372:
URL: https://github.com/apache/jena/pull/2372#issuecomment-2022485301
Fixed, only the branch name remains gh-2370, but I think that's harmless. Sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] GH-2371: Add tooltip to progress bars (via title attr) [jena]
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow merged PR #2372:
URL: https://github.com/apache/jena/pull/2372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] GH-2370: Add tooltip to progress bars (via title attr) [jena]
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #2372:
URL: https://github.com/apache/jena/pull/2372#issuecomment-2022463455
And I think it should be OK to skip tests for this one (not sure how hard/easy it'd be to test that the tooltip appears... we could test for the title attribute if others want...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] GH-2370: Add tooltip to progress bars (via title attr) [jena]
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #2372:
URL: https://github.com/apache/jena/pull/2372#issuecomment-2022482524
Used wrong GH issue :face_exhaling: give me a sec to fix that...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org