You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/02 16:53:42 UTC

[GitHub] [superset] eschutho opened a new pull request #16031: fix: add feature flag to header bar

eschutho opened a new pull request #16031:
URL: https://github.com/apache/superset/pull/16031


   ### SUMMARY
   Removes the add report icon from the header bar when feature flag is not enabled. Also prevents fetching the report list without proper access to the endpoint. 
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   With feature flag off you should not be able to create a report from a chart or dashboard. There should be no buttons or any sort of indication that you can create a report. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #16031: fix: add feature flag to header bar

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #16031:
URL: https://github.com/apache/superset/pull/16031#issuecomment-891192349


   # [Codecov](https://codecov.io/gh/apache/superset/pull/16031?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#16031](https://codecov.io/gh/apache/superset/pull/16031?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8cfa65b) into [master](https://codecov.io/gh/apache/superset/commit/5031a67597f584122917b87508a430c47ee0fbee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5031a67) will **decrease** coverage by `0.02%`.
   > The diff coverage is `17.64%`.
   
   > :exclamation: Current head 8cfa65b differs from pull request most recent head ca62b93. Consider uploading reports for the commit ca62b93 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/16031/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/16031?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #16031      +/-   ##
   ==========================================
   - Coverage   76.68%   76.66%   -0.03%     
   ==========================================
     Files         995      995              
     Lines       52774    52783       +9     
     Branches     6691     6695       +4     
   ==========================================
   - Hits        40472    40466       -6     
   - Misses      12077    12092      +15     
     Partials      225      225              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `71.28% <17.64%> (-0.05%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/16031?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/16031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `63.74% <14.28%> (-1.74%)` | :arrow_down: |
   | [...tend/src/explore/components/ExploreChartHeader.jsx](https://codecov.io/gh/apache/superset/pull/16031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIuanN4) | `56.33% <14.28%> (-3.96%)` | :arrow_down: |
   | [.../ReportModal/HeaderReportActionsDropdown/index.tsx](https://codecov.io/gh/apache/superset/pull/16031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvSGVhZGVyUmVwb3J0QWN0aW9uc0Ryb3Bkb3duL2luZGV4LnRzeA==) | `25.71% <33.33%> (+0.71%)` | :arrow_up: |
   | [superset-frontend/src/reports/actions/reports.js](https://codecov.io/gh/apache/superset/pull/16031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlcG9ydHMvYWN0aW9ucy9yZXBvcnRzLmpz) | `10.86% <0.00%> (-10.87%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16031?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16031?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5031a67...ca62b93](https://codecov.io/gh/apache/superset/pull/16031?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] betodealmeida commented on a change in pull request #16031: fix: add feature flag to header bar

Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #16031:
URL: https://github.com/apache/superset/pull/16031#discussion_r681140101



##########
File path: superset-frontend/package.json
##########
@@ -67,35 +67,35 @@
     "@emotion/babel-preset-css-prop": "^11.2.0",
     "@emotion/cache": "^11.1.3",
     "@emotion/react": "^11.1.5",
-    "@superset-ui/chart-controls": "^0.17.74",
-    "@superset-ui/core": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-calendar": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-chord": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-country-map": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-event-flow": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-force-directed": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-heatmap": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-histogram": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-horizon": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-map-box": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-paired-t-test": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-parallel-coordinates": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-partition": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-pivot-table": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-rose": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-sankey": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-sankey-loop": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-sunburst": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-treemap": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-world-map": "^0.17.74",
-    "@superset-ui/legacy-preset-chart-big-number": "^0.17.74",
+    "@superset-ui/chart-controls": "^0.17.75",

Review comment:
       Are these updates intentional?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho merged pull request #16031: fix: add feature flag to header bar

Posted by GitBox <gi...@apache.org>.
eschutho merged pull request #16031:
URL: https://github.com/apache/superset/pull/16031


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on a change in pull request #16031: fix: add feature flag to header bar

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #16031:
URL: https://github.com/apache/superset/pull/16031#discussion_r681165280



##########
File path: superset-frontend/package.json
##########
@@ -67,35 +67,35 @@
     "@emotion/babel-preset-css-prop": "^11.2.0",
     "@emotion/cache": "^11.1.3",
     "@emotion/react": "^11.1.5",
-    "@superset-ui/chart-controls": "^0.17.74",
-    "@superset-ui/core": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-calendar": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-chord": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-country-map": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-event-flow": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-force-directed": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-heatmap": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-histogram": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-horizon": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-map-box": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-paired-t-test": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-parallel-coordinates": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-partition": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-pivot-table": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-rose": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-sankey": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-sankey-loop": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-sunburst": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-treemap": "^0.17.74",
-    "@superset-ui/legacy-plugin-chart-world-map": "^0.17.74",
-    "@superset-ui/legacy-preset-chart-big-number": "^0.17.74",
+    "@superset-ui/chart-controls": "^0.17.75",

Review comment:
       yes, the feature flag ALERTS_REPORT wasn't in the list which resides on superset-ui. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org