You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2019/06/24 07:26:35 UTC

[GitHub] [guacamole-client] mike-jumper opened a new pull request #418: GUACAMOLE-822: Correct retrieval of client identifier for connection groups.

mike-jumper opened a new pull request #418: GUACAMOLE-822: Correct retrieval of client identifier for connection groups.
URL: https://github.com/apache/guacamole-client/pull/418
 
 
   Commit f92bf9c moved the `getClientIdentifier()` function to the `GroupListItem` class, thus making the function available as `item.getClientIdentifier()` within the connection or connection group templates referenced by an instance of the `guacGroupList` directive (see #391). That commit correctly updated all but the connection group template for the home screen, which was _incorrectly_ updated to reference the function as if it were directly on the scope. As such a function doesn't exist, AngularJS didn't substitute any value, resulting in non-functional connection group links.
   
   This change updates the home screen connection group template to retrieve the client identifier using `item.getClientIdentifier()`, as originally intended.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services