You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by jo...@apache.org on 2023/03/06 09:24:44 UTC
svn commit: r1908116 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/http2/mod_proxy_http2.c
Author: jorton
Date: Mon Mar 6 09:24:44 2023
New Revision: 1908116
URL: http://svn.apache.org/viewvc?rev=1908116&view=rev
Log:
* modules/http2/mod_proxy_http2.c: Fix missing APLOGNO.
Modified:
httpd/httpd/trunk/docs/log-message-tags/next-number
httpd/httpd/trunk/modules/http2/mod_proxy_http2.c
Modified: httpd/httpd/trunk/docs/log-message-tags/next-number
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/log-message-tags/next-number?rev=1908116&r1=1908115&r2=1908116&view=diff
==============================================================================
--- httpd/httpd/trunk/docs/log-message-tags/next-number (original)
+++ httpd/httpd/trunk/docs/log-message-tags/next-number Mon Mar 6 09:24:44 2023
@@ -1 +1 @@
-10412
+10413
Modified: httpd/httpd/trunk/modules/http2/mod_proxy_http2.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/mod_proxy_http2.c?rev=1908116&r1=1908115&r2=1908116&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/http2/mod_proxy_http2.c (original)
+++ httpd/httpd/trunk/modules/http2/mod_proxy_http2.c Mon Mar 6 09:24:44 2023
@@ -167,7 +167,7 @@ static int proxy_http2_canon(request_rec
* We have a raw control character or a ' ' in r->args.
* Correct encoding was missed.
*/
- ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, APLOGNO()
+ ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, APLOGNO(10412)
"To be forwarded query string contains control "
"characters or spaces");
return HTTP_FORBIDDEN;
Re: svn commit: r1908116 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/http2/mod_proxy_http2.c
Posted by Stefan Eissing via dev <de...@httpd.apache.org>.
> Am 06.03.2023 um 10:37 schrieb Yann Ylavic <yl...@gmail.com>:
>
> On Mon, Mar 6, 2023 at 10:28 AM Ruediger Pluem <rp...@apache.org> wrote:
>>
>> Thanks. Should we roll a new rc with this being backported and included?
>
> I don't think so, the ci failure is caused by an explicit script/check
> but the build works fine while runtime will only log an empty "AH"
> number, not a show stopper IMO.
Agreed, not a stopper.
And we can always find the one code line with an empty AH! ;)
>
> Regards;
> Yann.
Re: svn commit: r1908116 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/http2/mod_proxy_http2.c
Posted by Yann Ylavic <yl...@gmail.com>.
On Mon, Mar 6, 2023 at 10:28 AM Ruediger Pluem <rp...@apache.org> wrote:
>
> Thanks. Should we roll a new rc with this being backported and included?
I don't think so, the ci failure is caused by an explicit script/check
but the build works fine while runtime will only log an empty "AH"
number, not a show stopper IMO.
Regards;
Yann.
Re: svn commit: r1908116 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/http2/mod_proxy_http2.c
Posted by Ruediger Pluem <rp...@apache.org>.
On 3/6/23 10:24 AM, jorton@apache.org wrote:
> Author: jorton
> Date: Mon Mar 6 09:24:44 2023
> New Revision: 1908116
>
> URL: http://svn.apache.org/viewvc?rev=1908116&view=rev
> Log:
> * modules/http2/mod_proxy_http2.c: Fix missing APLOGNO.
>
> Modified:
> httpd/httpd/trunk/docs/log-message-tags/next-number
> httpd/httpd/trunk/modules/http2/mod_proxy_http2.c
>
> Modified: httpd/httpd/trunk/docs/log-message-tags/next-number
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/log-message-tags/next-number?rev=1908116&r1=1908115&r2=1908116&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/docs/log-message-tags/next-number (original)
> +++ httpd/httpd/trunk/docs/log-message-tags/next-number Mon Mar 6 09:24:44 2023
> @@ -1 +1 @@
> -10412
> +10413
>
> Modified: httpd/httpd/trunk/modules/http2/mod_proxy_http2.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/mod_proxy_http2.c?rev=1908116&r1=1908115&r2=1908116&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/http2/mod_proxy_http2.c (original)
> +++ httpd/httpd/trunk/modules/http2/mod_proxy_http2.c Mon Mar 6 09:24:44 2023
> @@ -167,7 +167,7 @@ static int proxy_http2_canon(request_rec
> * We have a raw control character or a ' ' in r->args.
> * Correct encoding was missed.
> */
> - ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, APLOGNO()
> + ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, APLOGNO(10412)
> "To be forwarded query string contains control "
> "characters or spaces");
> return HTTP_FORBIDDEN;
>
>
>
Thanks. Should we roll a new rc with this being backported and included?
Regards
Rüdiger