You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2017/10/06 08:55:56 UTC

Review Request 62804: Formatted 'synchronized' like loop instead of function.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62804/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Repository: mesos


Description
-------

We typically format 'synchronized' like a loop, i.e., we prefer

    // Loop-like formatting.
    synchronized (lock) {
      // Body.
    }

over e.g.,

    // Function-like formatting.
    synchronized(lock)
    {
      // Body.
    }

This patch updates the clang-format configuration to treat
'synchronized' blocks like loops instead of functions. This just
codifies the existing convention in the code, so that this is a NFC.


Diffs
-----

  support/clang-format bb587027a6c5b3660552a654ec06766c3ed0f6fe 


Diff: https://reviews.apache.org/r/62804/diff/1/


Testing
-------

Confirmed that this formats like advertized.


Thanks,

Benjamin Bannier


Re: Review Request 62804: Formatted 'synchronized' like loop instead of function.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62804/#review187250
-----------------------------------------------------------



FAIL: /usr/bin/rm: cannot remove 'C:mesos': Directory not empty

Reviews applied: `['62804']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62804

- Mesos Reviewbot Windows


On Oct. 6, 2017, 8:55 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62804/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2017, 8:55 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We typically format 'synchronized' like a loop, i.e., we prefer
> 
>     // Loop-like formatting.
>     synchronized (lock) {
>       // Body.
>     }
> 
> over e.g.,
> 
>     // Function-like formatting.
>     synchronized(lock)
>     {
>       // Body.
>     }
> 
> This patch updates the clang-format configuration to treat
> 'synchronized' blocks like loops instead of functions. This just
> codifies the existing convention in the code, so that this is a NFC.
> 
> 
> Diffs
> -----
> 
>   support/clang-format bb587027a6c5b3660552a654ec06766c3ed0f6fe 
> 
> 
> Diff: https://reviews.apache.org/r/62804/diff/1/
> 
> 
> Testing
> -------
> 
> Confirmed that this formats like advertized.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 62804: Formatted 'synchronized' like loop instead of function.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62804/#review187274
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On Oct. 6, 2017, 1:55 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62804/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2017, 1:55 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We typically format 'synchronized' like a loop, i.e., we prefer
> 
>     // Loop-like formatting.
>     synchronized (lock) {
>       // Body.
>     }
> 
> over e.g.,
> 
>     // Function-like formatting.
>     synchronized(lock)
>     {
>       // Body.
>     }
> 
> This patch updates the clang-format configuration to treat
> 'synchronized' blocks like loops instead of functions. This just
> codifies the existing convention in the code, so that this is a NFC.
> 
> 
> Diffs
> -----
> 
>   support/clang-format bb587027a6c5b3660552a654ec06766c3ed0f6fe 
> 
> 
> Diff: https://reviews.apache.org/r/62804/diff/1/
> 
> 
> Testing
> -------
> 
> Confirmed that this formats like advertized.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 62804: Formatted 'synchronized' like loop instead of function.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62804/#review187253
-----------------------------------------------------------



PASS: Mesos patch 62804 was successfully built and tested.

Reviews applied: `['62804']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62804

- Mesos Reviewbot Windows


On Oct. 6, 2017, 8:55 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62804/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2017, 8:55 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We typically format 'synchronized' like a loop, i.e., we prefer
> 
>     // Loop-like formatting.
>     synchronized (lock) {
>       // Body.
>     }
> 
> over e.g.,
> 
>     // Function-like formatting.
>     synchronized(lock)
>     {
>       // Body.
>     }
> 
> This patch updates the clang-format configuration to treat
> 'synchronized' blocks like loops instead of functions. This just
> codifies the existing convention in the code, so that this is a NFC.
> 
> 
> Diffs
> -----
> 
>   support/clang-format bb587027a6c5b3660552a654ec06766c3ed0f6fe 
> 
> 
> Diff: https://reviews.apache.org/r/62804/diff/1/
> 
> 
> Testing
> -------
> 
> Confirmed that this formats like advertized.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>