You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by iilyak <gi...@git.apache.org> on 2017/02/09 21:42:15 UTC
[GitHub] couchdb-chttpd pull request #155: Mock config module in tests
GitHub user iilyak opened a pull request:
https://github.com/apache/couchdb-chttpd/pull/155
Mock config module in tests
The tests in chttpd_db_bulk_get_test do not start config app.
The change in https://github.com/apache/couchdb-couch/pull/226
introduces call to config app.
Make sure we mock config so the tests pass.
COUCHDB-3293
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-chttpd couchdb-3293
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-chttpd/pull/155.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #155
----
commit fdfca9f0af73483fd5c4150ad46be1c79cd09165
Author: ILYA Khlopotov <ii...@apache.org>
Date: 2017-02-09T21:36:39Z
Mock config module in tests
The tests in chttpd_db_bulk_get_test do not start config app.
The change in https://github.com/apache/couchdb-couch/pull/226
introduces call to config app.
Make sure we mock config so the tests pass.
COUCHDB-3293
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd issue #155: Mock config module in tests
Posted by nickva <gi...@git.apache.org>.
Github user nickva commented on the issue:
https://github.com/apache/couchdb-chttpd/pull/155
Note: I couldn't reproduce this error locally. However I have seen similar failure when working on couch pr resulting from config being in the path of basic doc operations. The fix was similar to here so and tests still pass with the pr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request #155: Mock config module in tests
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-chttpd/pull/155
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd issue #155: Mock config module in tests
Posted by nickva <gi...@git.apache.org>.
Github user nickva commented on the issue:
https://github.com/apache/couchdb-chttpd/pull/155
+1
```
chttpd_error_info_tests: error_info_test (module 'chttpd_error_info_tests')...[0.010 s] ok
=======================================================
All 136 tests passed.
==> rel (eunit)
==> db-chttpd (eunit)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---