[GitHub] [hudi] leesf commented on a change in pull request #3299: [HUDI-2195] Sync Hive Failed When Execute CTAS In Spark2 And Spark3

[GitBox <gi...@apache.org>]

leesf commented on a change in pull request #3299:
URL: https://github.com/apache/hudi/pull/3299#discussion_r673886191



##########
File path: packaging/hudi-spark-bundle/pom.xml
##########
@@ -367,7 +369,18 @@
       <artifactId>curator-recipes</artifactId>
       <version>${zk-curator.version}</version>
     </dependency>
-
+<!--    import json to fix the crash when sync meta in spark-->
+    <dependency>
+      <groupId>org.json</groupId>
+      <artifactId>json</artifactId>
+      <version>20200518</version>

Review comment:
       define the version and dependency in parent pom?

##########
File path: packaging/hudi-spark-bundle/pom.xml
##########
@@ -367,7 +369,18 @@
       <artifactId>curator-recipes</artifactId>
       <version>${zk-curator.version}</version>
     </dependency>
-
+<!--    import json to fix the crash when sync meta in spark-->
+    <dependency>
+      <groupId>org.json</groupId>
+      <artifactId>json</artifactId>
+      <version>20200518</version>
+    </dependency>
+<!--    import calcite to support hive3 & spark 3-->
+    <dependency>
+      <groupId>org.apache.calcite</groupId>
+      <artifactId>calcite-core</artifactId>
+      <version>1.16.0</version>

Review comment:
       ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org