You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/15 18:25:47 UTC
[GitHub] [yunikorn-core] elihschiff opened a new pull request, #482: Fix typo in negative resource health check logging
elihschiff opened a new pull request, #482:
URL: https://github.com/apache/yunikorn-core/pull/482
### What is this PR for?
In the health check logs I was seeing `{"Name":"Negative resources","Succeeded":false,"Description":"Check for negative resources in the nodes","DiagnosisMessage":"Nodes with negative resources: []"}`
I noticed that there appears to be a typo where it is checking `nodesWithNegResources` but then logging the values of `partitionsWithNegResources`.
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
There is no Jira issue that I know of. This is my first time contributing. Should I open an issue for this change?
### How should this be tested?
I am not 100% sure the best way to test this.
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] craigcondit commented on pull request #482: Fix typo in negative resource health check logging
Posted by GitBox <gi...@apache.org>.
craigcondit commented on PR #482:
URL: https://github.com/apache/yunikorn-core/pull/482#issuecomment-1353721113
@elihschiff Hi, please open a JIRA for this, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] elihschiff commented on pull request #482: [YUNIKORN-1476] Fix typo in negative resource health check logging
Posted by GitBox <gi...@apache.org>.
elihschiff commented on PR #482:
URL: https://github.com/apache/yunikorn-core/pull/482#issuecomment-1353750529
@craigcondit Thanks for taking a look! I have opened a Jira issue here https://issues.apache.org/jira/browse/YUNIKORN-1476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #482: Fix typo in negative resource health check logging
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #482:
URL: https://github.com/apache/yunikorn-core/pull/482#issuecomment-1353725689
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/482?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#482](https://codecov.io/gh/apache/yunikorn-core/pull/482?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (554d5b9) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/43e656aabc35ea3e879162244f37a270704ba91b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (43e656a) will **increase** coverage by `0.11%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #482 +/- ##
==========================================
+ Coverage 72.77% 72.88% +0.11%
==========================================
Files 69 69
Lines 10207 10249 +42
==========================================
+ Hits 7428 7470 +42
Misses 2533 2533
Partials 246 246
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/482?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/health\_checker.go](https://codecov.io/gh/apache/yunikorn-core/pull/482/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9oZWFsdGhfY2hlY2tlci5nbw==) | `85.20% <100.00%> (ø)` | |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/yunikorn-core/pull/482/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.11% <100.00%> (+1.33%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s closed pull request #482: [YUNIKORN-1476] Fix typo in negative resource health check logging
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #482: [YUNIKORN-1476] Fix typo in negative resource health check logging
URL: https://github.com/apache/yunikorn-core/pull/482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org