[GitHub] [hudi] yanghua commented on a change in pull request #1797: [HUDI-1069] Remove duplicate assertNoWriteErrors()

[GitBox <gi...@apache.org>]

yanghua commented on a change in pull request #1797:
URL: https://github.com/apache/hudi/pull/1797#discussion_r451219310



##########
File path: hudi-client/src/test/java/org/apache/hudi/testutils/Assertions.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.testutils;
+
+import org.apache.hudi.client.WriteStatus;
+
+import org.apache.spark.api.java.JavaRDD;
+
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.assertAll;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+
+/**
+ * Commonly used assertion functions.
+ */
+public class Assertions {
+
+  /**
+   * Assert no failures in writing hoodie files.
+   */
+  public static void assertNoWriteErrors(JavaRDD<WriteStatus> statuses) {

Review comment:
       Hi @xushiyan I have a concern about open this method. Currently, @wangxianghu is refactoring client module #1727 . He is trying to decouple the dependency with Spark APIs. Maybe we'd better have this interface:
   
   ```
     public static void assertNoWriteErrors(List<WriteStatus> statuses) {
       //...
     }
   ```
   
   WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org