You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/08/07 20:27:58 UTC
Review Request 24461: Modified the default for ephemeral ports per container.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24461/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
Changed it to 1024 to align with prod setting. Also killed default ephemeral ports as users need to specify it anyway.
Diffs
-----
src/slave/constants.hpp a6bae1e
src/slave/constants.cpp 4339c7c
src/slave/containerizer/isolators/network/port_mapping.cpp daf89cc
src/tests/mesos.cpp b51954e
src/tests/port_mapping_tests.cpp 682325a
Diff: https://reviews.apache.org/r/24461/diff/
Testing
-------
make check
sudo make check
Thanks,
Jie Yu
Re: Review Request 24461: Modified the default for ephemeral ports per
container.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24461/#review49973
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 7, 2014, 6:27 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24461/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2014, 6:27 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Changed it to 1024 to align with prod setting. Also killed default ephemeral ports as users need to specify it anyway.
>
>
> Diffs
> -----
>
> src/slave/constants.hpp a6bae1e
> src/slave/constants.cpp 4339c7c
> src/slave/containerizer/isolators/network/port_mapping.cpp daf89cc
> src/tests/mesos.cpp b51954e
> src/tests/port_mapping_tests.cpp 682325a
>
> Diff: https://reviews.apache.org/r/24461/diff/
>
>
> Testing
> -------
>
> make check
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>