You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2019/12/03 05:11:35 UTC

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2359: Improve SkipList memory usage tracking

kangkaisen commented on a change in pull request #2359: Improve SkipList memory usage tracking
URL: https://github.com/apache/incubator-doris/pull/2359#discussion_r352983630
 
 

 ##########
 File path: be/src/olap/skiplist.h
 ##########
 @@ -100,9 +101,11 @@ class SkipList {
 
     // Immutable after construction
     Comparator const compare_;
+    bool _can_dup;
 
 Review comment:
   _is_unique is better?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org