You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/02/24 12:52:48 UTC
[GitHub] [bookkeeper] zymap opened a new pull request #2626: Allow force compact entry log when disabling entrh log compaction
zymap opened a new pull request #2626:
URL: https://github.com/apache/bookkeeper/pull/2626
---
Master Issue: #2596
*Motivation*
Sometimes user will disable the entry log compaction to reduce the
I/O load. But we should allow forcing compact the entry even if
the entry log compaction is disabled.
*Modifications*
- Add a configuration to allow force compaction
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap commented on pull request #2626: Allow force compact entry log when disabling entry log compaction
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #2626:
URL: https://github.com/apache/bookkeeper/pull/2626#issuecomment-792398311
ping @eolivelli Could you please take a look again? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap commented on pull request #2626: Allow force compact entry log when disabling entrh log compaction
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #2626:
URL: https://github.com/apache/bookkeeper/pull/2626#issuecomment-787942304
ping @sijie
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2626: Allow force compact entry log when disabling entrh log compaction
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #2626:
URL: https://github.com/apache/bookkeeper/pull/2626#discussion_r584718658
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
##########
@@ -1450,6 +1451,27 @@ public ServerConfiguration setStatisticsEnabled(boolean enabled) {
return this;
}
+ /**
+ * Allow manually force compact the entry log or not.
+ *
+ * @param enable
+ * whether allow manually force compact the entry log or not.
+ * @return service configuration.
+ */
+ public ServerConfiguration setIsForceCompactionAllowWhenDisableCompaction(boolean enable) {
Review comment:
can you update this method (setForceAllowCompaction) as well ?
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
##########
@@ -1450,6 +1451,27 @@ public ServerConfiguration setStatisticsEnabled(boolean enabled) {
return this;
}
+ /**
+ * Allow manually force compact the entry log or not.
+ *
+ * @param enable
+ * whether allow manually force compact the entry log or not.
+ * @return service configuration.
+ */
+ public ServerConfiguration setIsForceCompactionAllowWhenDisableCompaction(boolean enable) {
+ setProperty(IS_FORCE_COMPACTION_ALLOW_WHEN_DISABLE_COMPACTION, enable);
+ return this;
+ }
+
+ /**
+ * The force compaction is allowed or not when disabling the entry log compaction.
+ *
+ * @return the force compaction is allowed or not when disabling the entry log compaction.
+ */
+ public boolean isForceCompactionAllowWhenDisableCompaction() {
Review comment:
can you update this method (isForceAllowCompaction) as well ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2626: Allow force compact entry log when disabling entrh log compaction
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #2626:
URL: https://github.com/apache/bookkeeper/pull/2626#discussion_r581962554
##########
File path: conf/bk_server.conf
##########
@@ -476,7 +476,13 @@ ledgerDirectories=/tmp/bk-data
## Entry log compaction settings
#############################################################################
-# Set the rate at which compaction will readd entries. The unit is adds per second.
+# Allow force compaction when disabling the entry log compaction or not.
+# It will enable you to manually force compact the entry log even if
+# the entry log compaction is disabled. The 'minorCompactionThreshold' or
+# 'majorCompactionThreshold' still needs to be specified.
+# isForceCompactionAllowWhenDisableCompaction=false
Review comment:
what about "forceAllowCompaction" ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2626: Allow force compact entry log when disabling entry log compaction
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2626:
URL: https://github.com/apache/bookkeeper/pull/2626#issuecomment-792677844
committed to master branch, thank you @zymap !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #2626: Allow force compact entry log when disabling entry log compaction
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #2626:
URL: https://github.com/apache/bookkeeper/pull/2626
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap commented on pull request #2626: Allow force compact entry log when disabling entrh log compaction
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #2626:
URL: https://github.com/apache/bookkeeper/pull/2626#issuecomment-790432437
rerun failure checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org