You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by edespino <gi...@git.apache.org> on 2017/02/15 00:31:18 UTC
[GitHub] incubator-hawq pull request #1124: HAWQ-1330. More ASF header updates (inclu...
GitHub user edespino opened a pull request:
https://github.com/apache/incubator-hawq/pull/1124
HAWQ-1330. More ASF header updates (including pom.xml update)
Here are more ASF license header updates. I have verified the change in a dev pipeline ()https://hawq.ci.pivotalci.info/teams/main/pipelines/hdb-espino). I would like to push this change for the upcoming Apache 2.2.0.0-incubating RC1 release.
-=e
Reviewer requests: @amyrazz44 @paul-guo- @radarwave @stanlyxiang @huor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/edespino/incubator-hawq HAWQ-1330
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1124.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1124
----
commit bd52b584fd2ca2dadf4a896aa5fb8243db9d8983
Author: Ed Espino <ee...@pivotal.io>
Date: 2017-02-14T19:26:16Z
HAWQ-1330. More ASF header updates (including pom.xml update)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1124: HAWQ-1330. More ASF header updates (inclu...
Posted by edespino <gi...@git.apache.org>.
Github user edespino commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1124#discussion_r101207986
--- Diff: pom.xml ---
@@ -129,39 +129,88 @@
<exclude>src/pl/**/*</exclude>
<exclude>src/port/*</exclude>
<exclude>src/template/*</exclude>
- <exclude>src/test/**/*.in</exclude>
- <exclude>src/test/**/*.mdp</exclude>
+
+ <!-- src/test/bench -->
+
+ <exclude>src/test/bench/query*</exclude>
+
+ <!-- PostgreSQL src/test/regress -->
+
+ <exclude>src/test/regress/**/*.in</exclude>
+ <exclude>src/test/regress/**/*.mdp</exclude>
+ <exclude>src/test/regress/**/*.xml</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_3chars_line_delimiter.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_big.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_no_line_delimiter.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_out.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_blankfields.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_blankfields_and_nulls.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_correct.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_fieldtoolong.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_fieldtype.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_rejectlimitcrossed.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_rejectlimitnotcrossed.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_toofewfields.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_toomanyfields.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_nulldefined.tbl</exclude>
+ <exclude>src/test/regress/data/nation.tbl</exclude>
+ <exclude>src/test/regress/data/nation_error50.tbl</exclude>
+ <exclude>src/test/regress/data/region.tbl</exclude>
+ <exclude>src/test/regress/expected_statuses</exclude>
+
+ <!-- src/test/feature -->
+
+ <exclude>src/test/feature/ExternalSource/data/nation.tbl</exclude>
+ <exclude>src/test/feature/ExternalSource/data/nation_error50.tbl</exclude>
+ <exclude>src/test/feature/ExternalSource/data/region.tbl</exclude>
+ <exclude>src/test/feature/ManagementTool/test_hawq_register_hawq.paq</exclude>
+ <exclude>src/test/feature/ManagementTool/test_hawq_register_hive.paq</exclude>
+ <exclude>src/test/feature/ManagementTool/data/parquet200/dat.paq</exclude>
+ <exclude>src/test/feature/ManagementTool/data/parquet200sum/a.paq</exclude>
+ <exclude>src/test/feature/ManagementTool/data/parquet200sum/b.paq</exclude>
+ <exclude>src/test/feature/ManagementTool/test_hawq_register_data_types.paq</exclude>
--- End diff --
I'm afraid we will not question files which do not have ASF headers if we use directory wild cards so freely. As an example, the following was excluded but should have had a header:
<exclude>src/test/**/init_file</exclude>
Thank you for helping us think through this. It helps us all in the end. For now, I would like to be explicit in our exclusions. We can revisit if it becomes a significant maintenance issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1124: HAWQ-1330. More ASF header updates (inclu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1124
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1124: HAWQ-1330. More ASF header updates (including po...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the issue:
https://github.com/apache/incubator-hawq/pull/1124
@edespino, is there any rule indicate which type of files need to be excluded in the RAT?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1124: HAWQ-1330. More ASF header updates (including po...
Posted by ljainpivotalio <gi...@git.apache.org>.
Github user ljainpivotalio commented on the issue:
https://github.com/apache/incubator-hawq/pull/1124
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1124: HAWQ-1330. More ASF header updates (inclu...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1124#discussion_r101181207
--- Diff: pom.xml ---
@@ -129,39 +129,88 @@
<exclude>src/pl/**/*</exclude>
<exclude>src/port/*</exclude>
<exclude>src/template/*</exclude>
- <exclude>src/test/**/*.in</exclude>
- <exclude>src/test/**/*.mdp</exclude>
+
+ <!-- src/test/bench -->
+
+ <exclude>src/test/bench/query*</exclude>
+
+ <!-- PostgreSQL src/test/regress -->
+
+ <exclude>src/test/regress/**/*.in</exclude>
+ <exclude>src/test/regress/**/*.mdp</exclude>
+ <exclude>src/test/regress/**/*.xml</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_3chars_line_delimiter.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_big.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_no_line_delimiter.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_out.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_blankfields.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_blankfields_and_nulls.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_correct.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_fieldtoolong.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_fieldtype.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_rejectlimitcrossed.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_rejectlimitnotcrossed.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_toofewfields.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_toomanyfields.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_nulldefined.tbl</exclude>
+ <exclude>src/test/regress/data/nation.tbl</exclude>
+ <exclude>src/test/regress/data/nation_error50.tbl</exclude>
+ <exclude>src/test/regress/data/region.tbl</exclude>
+ <exclude>src/test/regress/expected_statuses</exclude>
+
+ <!-- src/test/feature -->
+
+ <exclude>src/test/feature/ExternalSource/data/nation.tbl</exclude>
+ <exclude>src/test/feature/ExternalSource/data/nation_error50.tbl</exclude>
+ <exclude>src/test/feature/ExternalSource/data/region.tbl</exclude>
+ <exclude>src/test/feature/ManagementTool/test_hawq_register_hawq.paq</exclude>
+ <exclude>src/test/feature/ManagementTool/test_hawq_register_hive.paq</exclude>
+ <exclude>src/test/feature/ManagementTool/data/parquet200/dat.paq</exclude>
+ <exclude>src/test/feature/ManagementTool/data/parquet200sum/a.paq</exclude>
+ <exclude>src/test/feature/ManagementTool/data/parquet200sum/b.paq</exclude>
+ <exclude>src/test/feature/ManagementTool/test_hawq_register_data_types.paq</exclude>
--- End diff --
Maybe we should use wildcat for .paq and .tbl files here. I've been thinking of having an extension standard in our dev/test code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1124: HAWQ-1330. More ASF header updates (including po...
Posted by edespino <gi...@git.apache.org>.
Github user edespino commented on the issue:
https://github.com/apache/incubator-hawq/pull/1124
@huor - there are no such rules. Our use is dependent on our needs. My main goal is to avoid accidentally excluding files from being scanned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1124: HAWQ-1330. More ASF header updates (including po...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the issue:
https://github.com/apache/incubator-hawq/pull/1124
@edespino, thanks for the update. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1124: HAWQ-1330. More ASF header updates (inclu...
Posted by edespino <gi...@git.apache.org>.
Github user edespino commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1124#discussion_r101183086
--- Diff: pom.xml ---
@@ -129,39 +129,88 @@
<exclude>src/pl/**/*</exclude>
<exclude>src/port/*</exclude>
<exclude>src/template/*</exclude>
- <exclude>src/test/**/*.in</exclude>
- <exclude>src/test/**/*.mdp</exclude>
+
+ <!-- src/test/bench -->
+
+ <exclude>src/test/bench/query*</exclude>
+
+ <!-- PostgreSQL src/test/regress -->
+
+ <exclude>src/test/regress/**/*.in</exclude>
+ <exclude>src/test/regress/**/*.mdp</exclude>
+ <exclude>src/test/regress/**/*.xml</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_3chars_line_delimiter.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_big.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_no_line_delimiter.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_out.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_blankfields.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_blankfields_and_nulls.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_correct.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_fieldtoolong.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_fieldtype.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_rejectlimitcrossed.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_rejectlimitnotcrossed.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_toofewfields.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_toomanyfields.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_nulldefined.tbl</exclude>
+ <exclude>src/test/regress/data/nation.tbl</exclude>
+ <exclude>src/test/regress/data/nation_error50.tbl</exclude>
+ <exclude>src/test/regress/data/region.tbl</exclude>
+ <exclude>src/test/regress/expected_statuses</exclude>
+
+ <!-- src/test/feature -->
+
+ <exclude>src/test/feature/ExternalSource/data/nation.tbl</exclude>
+ <exclude>src/test/feature/ExternalSource/data/nation_error50.tbl</exclude>
+ <exclude>src/test/feature/ExternalSource/data/region.tbl</exclude>
+ <exclude>src/test/feature/ManagementTool/test_hawq_register_hawq.paq</exclude>
+ <exclude>src/test/feature/ManagementTool/test_hawq_register_hive.paq</exclude>
+ <exclude>src/test/feature/ManagementTool/data/parquet200/dat.paq</exclude>
+ <exclude>src/test/feature/ManagementTool/data/parquet200sum/a.paq</exclude>
+ <exclude>src/test/feature/ManagementTool/data/parquet200sum/b.paq</exclude>
+ <exclude>src/test/feature/ManagementTool/test_hawq_register_data_types.paq</exclude>
--- End diff --
I am trying to limit our use of the wildcards thus forcing us to be as explicit as possible. The dev community will come to understand the importance of maintaining ASF headers as needed. Additionally, we have Apache RAT in place to allow a developer to catch potential issues as early as possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1124: HAWQ-1330. More ASF header updates (inclu...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1124#discussion_r101189224
--- Diff: pom.xml ---
@@ -129,39 +129,88 @@
<exclude>src/pl/**/*</exclude>
<exclude>src/port/*</exclude>
<exclude>src/template/*</exclude>
- <exclude>src/test/**/*.in</exclude>
- <exclude>src/test/**/*.mdp</exclude>
+
+ <!-- src/test/bench -->
+
+ <exclude>src/test/bench/query*</exclude>
+
+ <!-- PostgreSQL src/test/regress -->
+
+ <exclude>src/test/regress/**/*.in</exclude>
+ <exclude>src/test/regress/**/*.mdp</exclude>
+ <exclude>src/test/regress/**/*.xml</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_3chars_line_delimiter.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_big.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_no_line_delimiter.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_out.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_blankfields.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_blankfields_and_nulls.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_correct.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_fieldtoolong.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_fieldtype.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_rejectlimitcrossed.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_rejectlimitnotcrossed.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_toofewfields.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_error_toomanyfields.tbl</exclude>
+ <exclude>src/test/regress/data/fixedwidth/fixedwidth_small_nulldefined.tbl</exclude>
+ <exclude>src/test/regress/data/nation.tbl</exclude>
+ <exclude>src/test/regress/data/nation_error50.tbl</exclude>
+ <exclude>src/test/regress/data/region.tbl</exclude>
+ <exclude>src/test/regress/expected_statuses</exclude>
+
+ <!-- src/test/feature -->
+
+ <exclude>src/test/feature/ExternalSource/data/nation.tbl</exclude>
+ <exclude>src/test/feature/ExternalSource/data/nation_error50.tbl</exclude>
+ <exclude>src/test/feature/ExternalSource/data/region.tbl</exclude>
+ <exclude>src/test/feature/ManagementTool/test_hawq_register_hawq.paq</exclude>
+ <exclude>src/test/feature/ManagementTool/test_hawq_register_hive.paq</exclude>
+ <exclude>src/test/feature/ManagementTool/data/parquet200/dat.paq</exclude>
+ <exclude>src/test/feature/ManagementTool/data/parquet200sum/a.paq</exclude>
+ <exclude>src/test/feature/ManagementTool/data/parquet200sum/b.paq</exclude>
+ <exclude>src/test/feature/ManagementTool/test_hawq_register_data_types.paq</exclude>
--- End diff --
I think we should limit using wildcard for directory, etc, but not for file extensions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---