You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/26 05:16:16 UTC

[GitHub] [arrow] projjal commented on a change in pull request #10385: ARROW-12858: [C++][Gandiva] Add isNull, isTrue and isFalse functions on Gandiva

projjal commented on a change in pull request #10385:
URL: https://github.com/apache/arrow/pull/10385#discussion_r639406673



##########
File path: cpp/src/gandiva/function_registry_datetime.cc
##########
@@ -36,6 +36,7 @@ namespace gandiva {
 
 std::vector<NativeFunction> GetDateTimeFunctionRegistry() {
   static std::vector<NativeFunction> date_time_fn_registry_ = {
+      UNARY_SAFE_NULL_NEVER_BOOL(isnull, {}, day_time_interval),

Review comment:
       can you add isnull to all the types?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org