You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Cloudera) (Code Review)" <ge...@cloudera.org> on 2022/07/31 21:13:08 UTC
[Impala-ASF-CR] Update gerrit-auto-critic for a virtualenv API change
Laszlo Gaal (Cloudera) has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18800
Change subject: Update gerrit-auto-critic for a virtualenv API change
......................................................................
Update gerrit-auto-critic for a virtualenv API change
Recent versions of virtualenv have changed their main API during a
massive rewrite. This means that the create_environment entry point is
no longer available, scripts have to use 'cli_run' instead.
The patch updates the Gerrit auto-critic script for this change.
Change-Id: I6fb85622877b1d2835a1ed8f5a7df56185326949
---
M bin/jenkins/critique-gerrit-review.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/18800/1
--
To view, visit http://gerrit.cloudera.org:8080/18800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6fb85622877b1d2835a1ed8f5a7df56185326949
Gerrit-Change-Number: 18800
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal (Cloudera) <la...@cloudera.com>
[Impala-ASF-CR] Update gerrit-auto-critic for a virtualenv API change
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18800 )
Change subject: Update gerrit-auto-critic for a virtualenv API change
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb85622877b1d2835a1ed8f5a7df56185326949
Gerrit-Change-Number: 18800
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Aug 2022 23:02:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update gerrit-auto-critic for a virtualenv API change
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18800 )
Change subject: Update gerrit-auto-critic for a virtualenv API change
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb85622877b1d2835a1ed8f5a7df56185326949
Gerrit-Change-Number: 18800
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Aug 2022 15:10:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update gerrit-auto-critic for a virtualenv API change
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18800 )
Change subject: Update gerrit-auto-critic for a virtualenv API change
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8443/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb85622877b1d2835a1ed8f5a7df56185326949
Gerrit-Change-Number: 18800
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Aug 2022 10:10:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update gerrit-auto-critic for a virtualenv API change
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18800 )
Change subject: Update gerrit-auto-critic for a virtualenv API change
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb85622877b1d2835a1ed8f5a7df56185326949
Gerrit-Change-Number: 18800
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Aug 2022 10:10:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update gerrit-auto-critic for a virtualenv API change
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18800 )
Change subject: Update gerrit-auto-critic for a virtualenv API change
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11064/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb85622877b1d2835a1ed8f5a7df56185326949
Gerrit-Change-Number: 18800
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 31 Jul 2022 21:33:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Update gerrit-auto-critic for a virtualenv API change
Posted by "Laszlo Gaal (Cloudera) (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18800 )
Change subject: Update gerrit-auto-critic for a virtualenv API change
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18800/1/bin/jenkins/critique-gerrit-review.py
File bin/jenkins/critique-gerrit-review.py:
http://gerrit.cloudera.org:8080/#/c/18800/1/bin/jenkins/critique-gerrit-review.py@79
PS1, Line 79: virtualenv.cli_run([VENV_PATH])
Jenkins is currently running with this change in production, but the patch is sourced from my own Impala fork on Github.
This also required a change to the job's embedded build script so that the repo URL for the review scripts and the commit to be critiqued can be separated.
--
To view, visit http://gerrit.cloudera.org:8080/18800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb85622877b1d2835a1ed8f5a7df56185326949
Gerrit-Change-Number: 18800
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Aug 2022 22:35:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Update gerrit-auto-critic for a virtualenv API change
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18800 )
Change subject: Update gerrit-auto-critic for a virtualenv API change
......................................................................
Update gerrit-auto-critic for a virtualenv API change
Recent versions of virtualenv have changed their main API during a
massive rewrite. This means that the create_environment entry point is
no longer available, scripts have to use 'cli_run' instead.
The patch updates the Gerrit auto-critic script for this change.
Change-Id: I6fb85622877b1d2835a1ed8f5a7df56185326949
Reviewed-on: http://gerrit.cloudera.org:8080/18800
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/jenkins/critique-gerrit-review.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6fb85622877b1d2835a1ed8f5a7df56185326949
Gerrit-Change-Number: 18800
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>