You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "hililiwei (via GitHub)" <gi...@apache.org> on 2023/08/24 07:47:17 UTC
[GitHub] [iceberg] hililiwei opened a new pull request, #8384: Spark 3.4: Incremental scan specify branch
hililiwei opened a new pull request, #8384:
URL: https://github.com/apache/iceberg/pull/8384
Spark incremental scan specify branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spark 3.4: Incremental scan specify branch [iceberg]
Posted by "hililiwei (via GitHub)" <gi...@apache.org>.
hililiwei commented on PR #8384:
URL: https://github.com/apache/iceberg/pull/8384#issuecomment-2099651239
hi @amogh-jahagirdar, thank you for your review. I have made changes according to the comments. Would you please take a look again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #8384: Spark 3.4: Incremental scan specify branch
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #8384:
URL: https://github.com/apache/iceberg/pull/8384#discussion_r1312426429
##########
core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java:
##########
@@ -103,7 +103,22 @@ public static Iterable<Snapshot> currentAncestors(Table table) {
* @return a set of snapshot IDs of the known ancestor snapshots, including the current ID
*/
public static List<Long> currentAncestorIds(Table table) {
- return ancestorIds(table.currentSnapshot(), table::snapshot);
+ return currentAncestorIds(table, null);
+ }
+
+ /**
+ * Return the snapshot IDs for the ancestors of the current table state at a given branch.
+ *
+ * <p>Ancestor IDs are ordered by commit time, descending. The first ID is the current snapshot at
+ * a given branch, followed by its parent, and so on.
+ *
+ * @param table a {@link Table}
+ * @param branch branch name of the table (nullable)
+ * @return a set of snapshot IDs of the known ancestor snapshots, including the current ID
+ */
+ public static List<Long> currentAncestorIds(Table table, String branch) {
Review Comment:
Do we need the new API? Just want to avoid having to maintain another util API. It seems like we only use it in the new tests just to get the end snapshot for the incremental scan. In practice I think we would have the snapshot ID or it would just be a tagged snapshot which we could lookup the ID for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spark 3.4: Incremental scan specify branch [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8384:
URL: https://github.com/apache/iceberg/pull/8384#issuecomment-2364773514
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spark 3.4: Incremental scan specify branch [iceberg]
Posted by "hililiwei (via GitHub)" <gi...@apache.org>.
hililiwei commented on PR #8384:
URL: https://github.com/apache/iceberg/pull/8384#issuecomment-2148781543
@amogh-jahagirdar @nastra Would you please take a look again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spark 3.4: Incremental scan specify branch [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #8384: Spark 3.4: Incremental scan specify branch
URL: https://github.com/apache/iceberg/pull/8384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spark 3.4: Incremental scan specify branch [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8384:
URL: https://github.com/apache/iceberg/pull/8384#issuecomment-2350730590
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org