You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Peter Ertl (JIRA)" <ji...@apache.org> on 2007/12/17 16:26:43 UTC
[jira] Created: (WICKET-1233)
getMarkupSettings().setStripComments() is stripping too much
getMarkupSettings().setStripComments() is stripping too much
------------------------------------------------------------
Key: WICKET-1233
URL: https://issues.apache.org/jira/browse/WICKET-1233
Project: Wicket
Issue Type: Bug
Components: wicket
Reporter: Peter Ertl
I suppose stripComments()'s main purpose is to remove developers comments from the markup source. However, it's not only removing
<!-- comments -->
but also Microsoft Internet Explorers conditional comments which are, well, err, not exactly the same as traditional comments, if you ask me...
I guess most developers will agree it's better to _not_ remove comments like
<!--[if IE]>
<link rel="stylesheet" type="text/css" href="explorer_bugs.css"/>
-->
Maybe it's worth an extra settings setStripConditionalComments() ?!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1233)
getMarkupSettings().setStripComments() is stripping too much
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-1233.
----------------------------------------
Resolution: Invalid
Assignee: Juergen Donnerstag
the close tag must be <![endif]--> other Wicket will not identify it as a conditional and treat is as a standard comment. It would be nice though if Wicket would log an error on the missing <![endif]--> tag.
> getMarkupSettings().setStripComments() is stripping too much
> ------------------------------------------------------------
>
> Key: WICKET-1233
> URL: https://issues.apache.org/jira/browse/WICKET-1233
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Peter Ertl
> Assignee: Juergen Donnerstag
>
> I suppose stripComments()'s main purpose is to remove developers comments from the markup source. However, it's not only removing
> <!-- comments -->
> but also Microsoft Internet Explorers conditional comments which are, well, err, not exactly the same as traditional comments, if you ask me...
> I guess most developers will agree it's better to _not_ remove comments like
> <!--[if IE]>
> <link rel="stylesheet" type="text/css" href="explorer_bugs.css"/>
> -->
> Maybe it's worth an extra settings setStripConditionalComments() ?!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1233)
getMarkupSettings().setStripComments() is stripping too much
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552442 ]
Peter Ertl commented on WICKET-1233:
------------------------------------
You surely know that stuff already, but anyway here's a link to conditional comments:
http://msdn2.microsoft.com/en-us/library/ms537512.aspx
> getMarkupSettings().setStripComments() is stripping too much
> ------------------------------------------------------------
>
> Key: WICKET-1233
> URL: https://issues.apache.org/jira/browse/WICKET-1233
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Peter Ertl
>
> I suppose stripComments()'s main purpose is to remove developers comments from the markup source. However, it's not only removing
> <!-- comments -->
> but also Microsoft Internet Explorers conditional comments which are, well, err, not exactly the same as traditional comments, if you ask me...
> I guess most developers will agree it's better to _not_ remove comments like
> <!--[if IE]>
> <link rel="stylesheet" type="text/css" href="explorer_bugs.css"/>
> -->
> Maybe it's worth an extra settings setStripConditionalComments() ?!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-1233) getMarkupSettings().setStripComments()
is stripping too much
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Ertl closed WICKET-1233.
------------------------------
> getMarkupSettings().setStripComments() is stripping too much
> ------------------------------------------------------------
>
> Key: WICKET-1233
> URL: https://issues.apache.org/jira/browse/WICKET-1233
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Peter Ertl
> Assignee: Juergen Donnerstag
>
> I suppose stripComments()'s main purpose is to remove developers comments from the markup source. However, it's not only removing
> <!-- comments -->
> but also Microsoft Internet Explorers conditional comments which are, well, err, not exactly the same as traditional comments, if you ask me...
> I guess most developers will agree it's better to _not_ remove comments like
> <!--[if IE]>
> <link rel="stylesheet" type="text/css" href="explorer_bugs.css"/>
> -->
> Maybe it's worth an extra settings setStripConditionalComments() ?!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.