[GitHub] [airflow] mik-laj commented on a change in pull request #17426: Allow using default celery commands for custom Celery executors subclassed from existing

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #17426:
URL: https://github.com/apache/airflow/pull/17426#discussion_r683844854



##########
File path: airflow/cli/cli_parser.py
##########
@@ -60,10 +62,17 @@ def _check_value(self, action, value):
         if action.dest == 'subcommand' and value == 'celery':
             executor = conf.get('core', 'EXECUTOR')
             if executor not in (CELERY_EXECUTOR, CELERY_KUBERNETES_EXECUTOR):
-                message = (
-                    f'celery subcommand works only with CeleryExecutor, your current executor: {executor}'
-                )
-                raise ArgumentError(action, message)
+                executor_cls = import_string(ExecutorLoader.executors.get(executor, executor))

Review comment:
       I am not sure if this will allow the executor to load in all cases, and in particular if it works with executed provided by plugins.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org