[GitHub] [trafficcontrol] rob05c opened a new pull request #5713: Fix ORT adding remap lines for DSes not on Mids

[GitBox <gi...@apache.org>]

rob05c opened a new pull request #5713:
URL: https://github.com/apache/trafficcontrol/pull/5713


   Bug was ORT Mid remap gen not using the new lib/go-tc DSType
   UsesMidCache func, but having old code checking live and natnl,
   which ended up with HTTP_NO_CACHE generating remap lines on Mids.
   
   This could particularly cause issues because the hdr_rw_mid_ file
   generation did use ds.Type.UsesMidCache, potentially resulting
   in a remap line with a file that didn't exist, causing ATS to fail
   to load.
   
   This could be mitigated by creating a location Param for the file,
   to force it to be created.
   
   Note this did not affect Topologies, which use their own criteria
   for both header rewrite file and remap line generation.
   
   Includes tests.
   No changelog, no interface change, and bug is not in a release.
   No docs, no interface change.
   
   - [x] This PR is not related to any other Issue
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops ORT
   
   ## What is the best way to verify this PR?
   Run tests. Create a non-topology DS of type HTTP_NO_CACHE with a Mid Header Rewrite, run ORT, verify no remap line exists for the DS.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master
   
   ## The following criteria are ALL met by this PR
   
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   
   ## Additional Information


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] zrhoffman merged pull request #5713: Fix ORT adding remap lines for DSes not on Mids

[GitBox <gi...@apache.org>]

zrhoffman merged pull request #5713:
URL: https://github.com/apache/trafficcontrol/pull/5713


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org