You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Tomoko Uchida (JIRA)" <ji...@apache.org> on 2019/07/12 09:05:00 UTC

[jira] [Commented] (LUCENE-8911) Backport LUCENE-8778 (improved analysis SPI name handling) to 8.x

    [ https://issues.apache.org/jira/browse/LUCENE-8911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883658#comment-16883658 ] 

Tomoko Uchida commented on LUCENE-8911:
---------------------------------------

I do not have strong feeling about this, but I just start thinking that it could be better if we expose this feature from 8.x as pre-migration steps to 9.0 - especially if it affects to many Lucene and Solr users. Therefore quick-eyed custom factory authors can try their own names from now on. It should be easy to emulate old algorithm in a "lenient way" when the SPI NAME constant is not defined.

[~thetaphi] and [~jpountz]: Do you have any thoughts about this?

And of course we need to add some note about it in MIGRATE.txt anyway, I forgot that. I'll update it. Also, by the way, I feel like that it would be helpful if we can show warning messages for such use case though we don't need full-fledged loggers. But it's beyond the scope here.

> Backport LUCENE-8778 (improved analysis SPI name handling) to 8.x
> -----------------------------------------------------------------
>
>                 Key: LUCENE-8911
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8911
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>            Reporter: Tomoko Uchida
>            Priority: Minor
>
> In LUCENE-8907 I reverted LUCENE-8778 from the 8x branch.
> Can we backport it to 8x branch again, with transparent backwards compatibility (by emulating the factory loading method of Lucene 8.1)?
> I am not so sure about it would be better or not to backport the changes, however, maybe it is good for Solr to have SOLR-13593 without waiting for release 9.0.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org