You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/12/15 06:35:52 UTC

[GitHub] [incubator-dolphinscheduler] felix-thinkingdata commented on a change in pull request #3940: [Improvement-3933][db operation] Improve the performance of sql query

felix-thinkingdata commented on a change in pull request #3940:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3940#discussion_r543082765



##########
File path: dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProjectMapper.xml
##########
@@ -50,23 +72,29 @@
         order by p.create_time desc
     </select>
     <select id="queryAuthedProjectListByUserId" resultType="org.apache.dolphinscheduler.dao.entity.Project">
-        select p.*
+        select
+        <include refid="baseSqlV2">
+            <property name="alias" value="p"/>
+        </include>
+        ,

Review comment:
       sql Grammar mistakes




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org