You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Mikhail Efremov (Jira)" <ji...@apache.org> on 2025/02/18 16:05:00 UTC

[jira] [Commented] (IGNITE-24272) Search for inappropriate java system properties

    [ https://issues.apache.org/jira/browse/IGNITE-24272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928138#comment-17928138 ] 

Mikhail Efremov commented on IGNITE-24272:
------------------------------------------

I made a list of currently used system properties in AI3 codebase:
* Through {{IgniteSystemProperties}}'s methods calls.
** {{getBoolean(String)}}
*** Non-test
**** {{IGNITE_JVM_PAUSE_DETECTOR_DISABLED}}
**** {{IGNITE_PDS_SKIP_CRC}}
*** Test
**** {{SQL_LOGIC_TEST_INCLUDE_SLOW}}
** {{getBoolean(String, boolean)}}
*** Non-test
**** {{IGNITE_SKIP_REBALANCE_TRIGGERS_RECOVERY}} (IGNITE-23561)
**** {{IGNITE_PAGES_LIST_DISABLE_ONHEAP_CACHING}}
**** {{LOGIT_STORAGE_ENABLED}}
**** {{IMPLICIT_PK_ENABLED}}
**** {{FAST_QUERY_OPTIMIZATION_ENABLED}} (IGNITE-22821)
*** Test
**** {{MAPPING_TESTS_OVERWRITE_RESULTS}}
**** {{MAPPING_TESTS_STRIP_RESULTS}}
** -{{getDouble(String, double)}} wasn't used-
** -{{getEnum(Class<E>, String, E)}} wasn't used-
** {{getFloat(String, float)}}
*** Non-test
**** {{IGNITE_LONG_LONG_HASH_MAP_LOAD_FACTOR}} (IGNITE-16350)
** {{getInteger(String, int)}}
*** Non-test
**** {{IGNITE_JVM_PAUSE_DETECTOR_PRECISION}}
**** {{IGNITE_JVM_PAUSE_DETECTOR_THRESHOLD}}
**** {{IGNITE_JVM_PAUSE_DETECTOR_LAST_EVENTS_COUNT}}
**** {{IGNITE_PAGES_LIST_TRY_LOCK_ATTEMPTS}}
**** {{IGNITE_PAGES_LIST_STRIPES_PER_BUCKET}}
**** {{IGNITE_PAGES_LIST_CACHING_MAX_CACHE_SIZE}}
**** {{IGNITE_PAGES_LIST_CACHING_STRIPES_COUNT}}
**** {{IGNITE_PAGES_LIST_CACHING_EMPTY_FLUSH_GC_THRESHOLD}}
**** {{IGNITE_BPLUS_TREE_LOCK_RETRIES}} (IGNITE-16350)
**** {{IGNITE_OFFHEAP_LOCK_CONCURRENCY_LEVEL}}
**** {{IGNITE_OFFHEAP_RWLOCK_SPIN_COUNT}}
**** {{IGNITE_LOGIT_STORAGE_SEGMENT_FILE_SIZE}}
**** {{IGNITE_LOGIT_STORAGE_CONFIG_FILE_SIZE}}
**** {{RESOURCE_VACUUM_INTERVAL_MILLISECONDS}}
**** {{LEASE_STATISTICS_PRINT_ONCE_PER_ITERATIONS}}
** {{getLong(String, long)}}
*** Non-test
**** {{IGNITE_TIMEOUT_WORKER_SLEEP_INTERVAL}}
**** {{IGNITE_LOG_THROTTLE_INTERVAL_MS}}
*** Test
**** {{BPLUS_TREE_TEST_SEED}}
** {{getString(String)}}
*** Test
**** {{ARTIFACT_DIR}}
**** {{KEEP_WORK_DIR}}
** -{{getString(String, String)}} wasn't used-
* List of {{IgniteSystemProperties}}'s static fields
** {{IGNITE_SENSITIVE_DATA_LOGGING}}
** {{IGNITE_TO_STRING_COLLECTION_LIMIT}}
** {{IGNITE_TO_STRING_IGNORE_RUNTIME_EXCEPTION}}
** {{IGNITE_TO_STRING_MAX_LENGTH}}
** {{IGNITE_THREAD_ASSERTIONS_ENABLED}}
** {{THREAD_ASSERTIONS_LOG_BEFORE_THROWING}}
** {{IGNITE_SKIP_REPLICATION_IN_BENCHMARK}}
** {{IGNITE_SKIP_STORAGE_UPDATE_IN_BENCHMARK}}
** {{IGNITE_ZONE_BASED_REPLICATION}}
* System properties list that use {{System#getProperty}} method directly
** Non-test usage
*** {{user.home}} -> a standard one
*** {{sun.stdout.encoding}} -> jshell didn't show this one, but it looks like a standard one
*** {{os.arch}} -> a standard one
*** {{line.separator}} -> a standard one
*** {{java.specification.version}} -> a standard one
*** {{os.name}} -> a standard one
** Tests usage
*** {{buildDirPath}}
*** {{java.io.tmpdir}}
*** {{user.dir}}
*** {{archtest.dir}}
*** {{io.netty.leakDetectionLevel}}
*** {{java.class.path}}

There are newly created tickets for listed properties refinement sorted by engineering teams:
* https://issues.apache.org/jira/browse/IGNITE-24553 for Data Consistency team
* https://issues.apache.org/jira/browse/IGNITE-24554 for SQL team
* https://issues.apache.org/jira/browse/IGNITE-24555 for Storage Engine team

I couldn't make an argumentative decision what to do with "standard one" properties, so I left them as is for now.

> Search for inappropriate java system properties
> -----------------------------------------------
>
>                 Key: IGNITE-24272
>                 URL: https://issues.apache.org/jira/browse/IGNITE-24272
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Mikhail Efremov
>            Assignee: Mikhail Efremov
>            Priority: Major
>              Labels: ignite-3
>
> *Description*
> After a discussion there is an issue with system properties in AI3 code base that may be used as configuration tool instead of configuration files usage. The situation requires an actions and first of all to refine system properties: are they really an internal mechanisms for test-only purposes or some are mistaken and should be redone as configuration's entries.
> *Motivation*
> We should use strict policy for user accessible mechanisms as jvm properties.
> *Definition of Done*
> 1. All system properties are inspected and developers who added them are communicated.
> 2. All system properties that are intended for configuration should be mentioned in the new ticket about changing mistaken properties to configuration values.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)