You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by matrosov-nikita <gi...@git.apache.org> on 2017/05/10 09:16:56 UTC
[GitHub] cordova-lib pull request #554: CB-12738: Cordova ignores plugin dependency v...
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-lib/pull/554
CB-12738: Cordova ignores plugin dependency version on windows platform
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
windows
### What does this PR do?
Steps to reproduce w\ `cordova-7.0.2-dev`:
1) `cordova create sample`
2) `cordova platform add android`
3) `cordova plugin add cordova-plugin-file-transfer`
`Cordova-plugin-file-transfer` has `cordova-plugin-file@^4.0.0` as dependency and it should install the latest version (`4.4.3`), but after installation, I get `4.0.0`. Cordova treats `^` symbol as special in windows shell when running `npm.cmd install` and ignores it. We should enclose version range with quotes in case of windows platform.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosov-nikita/cordova-lib fix-plugin-dependency
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/554.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #554
----
commit d0c2bef764856f12cac0f77152ffb022d77ab3e1
Author: Nikita Matrosov <v-...@microsoft.com>
Date: 2017-05-10T08:58:51Z
CB-12738: Cordova ignore plugin dependency version on windows platform
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #554: CB-12738: Cordova ignores plugin dependency version ...
Posted by matrosov-nikita <gi...@git.apache.org>.
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-lib/pull/554
I'm investigating what's causing CI failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #554: CB-12738: Cordova ignores plugin dependency v...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/554
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #554: CB-12738: Cordova ignores plugin dependency version ...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/554
merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #554: CB-12738: Cordova ignores plugin dependency version ...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/554
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/554?src=pr&el=h1) Report
> Merging [#554](https://codecov.io/gh/apache/cordova-lib/pull/554?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/3962053f7f5c7c65259f9926a220671595c6d944?src=pr&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `62.5%`.
[](https://codecov.io/gh/apache/cordova-lib/pull/554?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #554 +/- ##
==========================================
- Coverage 79.48% 79.44% -0.05%
==========================================
Files 57 57
Lines 3944 3950 +6
Branches 828 830 +2
==========================================
+ Hits 3135 3138 +3
- Misses 809 812 +3
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/554?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cordova-lib/src/plugman/fetch.js](https://codecov.io/gh/apache/cordova-lib/pull/554?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vZmV0Y2guanM=) | `80.72% <62.5%> (-1.16%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/554?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/554?src=pr&el=footer). Last update [3962053...d0c2bef](https://codecov.io/gh/apache/cordova-lib/pull/554?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org